[webkit-dev] Upgrading the WebKitGTK+ 64-bit Debug build slave

2010-06-04 Thread Adrian Perez
Hello to all, Currently both WebKitGTK+ debug bots hosted at Igalia bots are being run in the same host. We will be moving the 64-bit one to a new machine and they will not share resources anymore, thus making the build cycle shorter. We plan to move the Buildbot installation to the new machine

Re: [webkit-dev] ask for WTF introduction

2010-06-04 Thread Tony Gentilcore
There's an excellent doc on some of WTF's smart pointers: http://webkit.org/coding/RefPtr.html I'm interested to hear if there are any other references out there too. On Fri, Jun 4, 2010 at 7:45 PM, Eric Zhou wrote: > Hi all, > > Could anyone give me some references about WTF, like tutorials or

[webkit-dev] ask for WTF introduction

2010-06-04 Thread Eric Zhou
Hi all, Could anyone give me some references about WTF, like tutorials or introduction? Thanks BR/Eric ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-06-04 Thread Grace Kloba
As promised, here is the bug to track this issue. https://bugs.webkit.org/show_bug.cgi?id=40197 Sorry about starting a new thread. I was not able to reply from the archive. On Fri, Jun 4, 2010 at 2:04 PM, Grace Kloba wrote: > We (Android) are also looking at this area. We are working on a patch

Re: [webkit-dev] Style question: static, protected, or public members

2010-06-04 Thread Joe Mason
I'm strongly in favour of g_. It seems weird and ugly to me to have prefixes for some non-local scopes but not all. And it's very helpful to be able to look at a variable reference and immediately know that it's a global, and not a local whose definition you skimmed over. Joe -Original Mess

[webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-06-04 Thread Grace Kloba
We (Android) are also looking at this area. We are working on a patch. Will file a bug and provide a patch for the feedback. thanks, Grace ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Darin Fisher
On Fri, Jun 4, 2010 at 11:15 AM, Peter Kasting wrote: > On Fri, Jun 4, 2010 at 11:11 AM, Darin Adler wrote: > >> If the two enum types are identical except for their names, then this >> doesn’t firewall the types at all. > > > It doesn't firewall the concepts (but then, it's hard for an embeddin

Re: [webkit-dev] On adding 'console.memory' API (and about the whole 'console' object.)

2010-06-04 Thread David Hyatt
Oh this is purely JS memory use? Hmm ok, my original example wouldn't work, but I still think I could construct an attack. Let me think about it some more. dave On Jun 4, 2010, at 2:31 PM, James Robinson wrote: > How? Visited state information is not stored in the javascript heap (which > i

Re: [webkit-dev] On adding 'console.memory' API (and about the whole 'console' object.)

2010-06-04 Thread David Hyatt
To get more specific, the style allocated for visited state is freed when you're an unvisited link to save memory (lots of memory), but it is not freed if you're visited. So there's a definite memory consumption difference. This memory difference would be magnified and obvious if you made 1000

Re: [webkit-dev] On adding 'console.memory' API (and about the whole 'console' object.)

2010-06-04 Thread James Robinson
How? Visited state information is not stored in the javascript heap (which is what this object contains information about). - James On Fri, Jun 4, 2010 at 12:06 PM, David Hyatt wrote: > I'm fairly certain I could construct an attack on :visited history privacy > using this object. > > dave > >

Re: [webkit-dev] About fixing "old" layout bugs

2010-06-04 Thread David Hyatt
For this particular bug (the one), even ref tests would be inadequate, since the reference renderings would have to change too. dave On Jun 4, 2010, at 2:17 PM, Dirk Pranke wrote: > One admittedly painful way to do this would be to dump two render > trees, an old format and a new format, and t

Re: [webkit-dev] On adding 'console.memory' API (and about the whole 'console' object.)

2010-06-04 Thread Sam Weinig
On Fri, Jun 4, 2010 at 12:02 PM, Ojan Vafai wrote: > On Fri, Jun 4, 2010 at 11:27 AM, Sam Weinig wrote: > >> After talking it over with some folks here at Apple, I want to formally >> object to adding the Console.memory extension to the Console object and I >> think we should remove support for

Re: [webkit-dev] About fixing "old" layout bugs

2010-06-04 Thread Dirk Pranke
One admittedly painful way to do this would be to dump two render trees, an old format and a new format, and then build tooling to roll between the versions. Most of the pain would probably be in modifying the dump code to accept version flags and know whether to output old or new as necessary. Of

Re: [webkit-dev] On adding 'console.memory' API (and about the whole 'console' object.)

2010-06-04 Thread David Hyatt
I'm fairly certain I could construct an attack on :visited history privacy using this object. dave On Jun 4, 2010, at 2:02 PM, Ojan Vafai wrote: > On Fri, Jun 4, 2010 at 11:27 AM, Sam Weinig wrote: > After talking it over with some folks here at Apple, I want to formally > object to adding th

Re: [webkit-dev] On adding 'console.memory' API (and about the whole 'console' object.)

2010-06-04 Thread Ojan Vafai
On Fri, Jun 4, 2010 at 11:27 AM, Sam Weinig wrote: > After talking it over with some folks here at Apple, I want to formally > object to adding the Console.memory extension to the Console object and I > think we should remove support for Console.profiles as soon as we can. They > both provide in

Re: [webkit-dev] On adding 'console.memory' API (and about the whole 'console' object.)

2010-06-04 Thread Sam Weinig
After talking it over with some folks here at Apple, I want to formally object to adding the Console.memory extension to the Console object and I think we should remove support for Console.profiles as soon as we can. They both provide information to users that are not generally useful (beyond the

Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Peter Kasting
On Fri, Jun 4, 2010 at 11:11 AM, Darin Adler wrote: > If the two enum types are identical except for their names, then this > doesn’t firewall the types at all. It doesn't firewall the concepts (but then, it's hard for an embedding layer to not transmit any concepts, as that's basically the poi

Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Darin Adler
If the two enum types are identical except for their names, then this doesn’t firewall the types at all. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Chris Fleizach
Was just hoping something easier might come along. I'll let the appropriate people know if I need any help thanx On Jun 4, 2010, at 11:04 AM, Peter Kasting wrote: > On Fri, Jun 4, 2010 at 10:54 AM, Chris Fleizach wrote: > For one, I would like to alphabetize that list. That will require hund

Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Peter Kasting
On Fri, Jun 4, 2010 at 10:54 AM, Chris Fleizach wrote: > For one, I would like to alphabetize that list. That will require hundreds > of changes, requiring me to make hundreds of blind changes in chromium code. > > When ARIA2 comes out, mayhaps there will be a dozen or two new additions. > OK, b

Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Darin Adler
For what it’s worth, this kind of pattern was quite common in the Mac OS X WebKit API, with public enums in the Objective-C API that exactly matched private enums inside WebCore and had to be kept in sync. Over the years, working towards the goal of making WebKit better cross-platform, we’ve tr

Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Chris Fleizach
For one, I would like to alphabetize that list. That will require hundreds of changes, requiring me to make hundreds of blind changes in chromium code. It seems like rather bad form to duplicate core WebCore code used by all platforms, within one platform, and not a solution that is forward loo

Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Peter Kasting
On Fri, Jun 4, 2010 at 10:14 AM, Chris Fleizach wrote: > Is there any way chromium can automate this so if it sees it is different, > it can re-generate to match the enums again Is it really that enormous of a problem? It doesn't seem like you're going to be making hundreds of changes, and mod

Re: [webkit-dev] About fixing "old" layout bugs

2010-06-04 Thread David Hyatt
In fact the (really lousy) model I've employed in the past when this situation has arisen is that I hack the render tree dump to continue to dump the old rendering. The render tree dumping code is full of hacks as a result and is basically lying about many things at this point. It would be rea

Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Chris Fleizach
Is there any way chromium can automate this so if it sees it is different, it can re-generate to match the enums again On Jun 4, 2010, at 10:04 AM, Adam Barth wrote: > [+fishd] > > I believe this is a common pattern in the Chromium WebKit API. fishd > can speak to why this works the way it doe

Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Adam Barth
[+fishd] I believe this is a common pattern in the Chromium WebKit API. fishd can speak to why this works the way it does in more detail. I believe these enums exist to encapsulate WebCore types in the interface. Adam On Fri, Jun 4, 2010 at 9:40 AM, Chris Fleizach wrote: > Could someone expl

[webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Chris Fleizach
Could someone explain why WebAccessibilityRole duplicates AccessibilityRole? This will make it very painful to change, re-order or add to AccessibilityRole as it becomes necessary in the future ie) see https://bugs.webkit.org/show_bug.cgi?id=40133 ___

Re: [webkit-dev] On adding 'console.memory' API (and about the whole 'console' object.)

2010-06-04 Thread Adam Barth
On Fri, Jun 4, 2010 at 1:54 AM, Mikhail Naganov wrote: > On Fri, Jun 4, 2010 at 05:57, Sam Weinig wrote: >> I should note, I don't think this is possible for JS objects, it certainly >> would not be possible for arbitrary WebCore/WebKit objects.  I noticed the >> patch was re-landed, which surpri

Re: [webkit-dev] On adding 'console.memory' API (and about the whole 'console' object.)

2010-06-04 Thread Mikhail Naganov
Comments are inline. On Fri, Jun 4, 2010 at 05:57, Sam Weinig wrote: > I should note, I don't think this is possible for JS objects, it certainly > would not be possible for arbitrary WebCore/WebKit objects.  I noticed the > patch was re-landed, which surprises me since we are still discussing it