Re: [webkit-dev] Constant readonly

2010-11-30 Thread Mario Bensi
Hi Darin, I understand. thanks for your help. Mario On lundi 22 novembre 2010 17:23:18 Darin Adler wrote: On Nov 22, 2010, at 2:41 AM, Mario Bensi wrote: I tested if the constant in idl was readonly, like that : var node = document.getElementById('console');

[webkit-dev] Waiting time for patch with commit? status.

2010-11-30 Thread Jia Pu
Hello, If I flag a patch with commit?, do I need to notify some commiters? Or are those commit? patches get periodically processed by someone, I just need to wait. If the latter is the case, what's the average waiting time. Thanks. Jia___ webkit-dev

Re: [webkit-dev] Waiting time for patch with commit? status.

2010-11-30 Thread Ojan Vafai
Sometimes some individuals take it upon themselves to process all the commit-queue? patches, but I don't think we have a formal process like we do with reviews. Pinging on the bug and/or on the #webkit IRC channel are both acceptable. On Tue, Nov 30, 2010 at 8:40 AM, Jia Pu j...@apple.com wrote:

Re: [webkit-dev] Waiting time for patch with commit? status.

2010-11-30 Thread Eric Seidel
Marking commit-queue? is just like marking review?. Mails get sent, but you often have to bug people to get your review+ or commit-queue+. -eric On Tue, Nov 30, 2010 at 8:40 AM, Jia Pu j...@apple.com wrote: Hello, If I flag a patch with commit?, do I need to notify some commiters? Or are

Re: [webkit-dev] Waiting time for patch with commit? status.

2010-11-30 Thread David Levin
I don't know if my behavior is typical but I almost never scan the commit queue. I occasionally scan the review queue. So changing an already r+'ed bug to have cq? may not get noticed. I'd ping someone to be sure (and there are more committers than reviewers so you have more options even). dave

Re: [webkit-dev] Faster Git SVN updates

2010-11-30 Thread Eric Seidel
I've now posted a patch to fix update-webkit as well: https://bugs.webkit.org/show_bug.cgi?id=50273 Once that lands, I'll move the EWS bots over to using this new setup. Assuming those stay working, we can teach the tools to offer to fix old setups. -eric On Mon, Nov 22, 2010 at 4:58 PM, Ojan

Re: [webkit-dev] Faster Git SVN updates

2010-11-30 Thread Eric Seidel
I am of the impression that now any git user need only run: git config --replace-all svn-remote.svn.fetch trunk:refs/remotes/origin/master in their get repo and updates will be faster. I'm doing so now on the EWS bots, and will fix any tooling issues in encounter. I think it's time that we

Re: [webkit-dev] Faster Git SVN updates

2010-11-30 Thread Ojan Vafai
On Tue, Nov 30, 2010 at 2:59 PM, Eric Seidel e...@webkit.org wrote: I think it's time that we consider adding a git section to http://webkit.org/building/checkout.html. +1 Anecdotally, I imagine there are more webkit developers using git now than svn. -eric On Tue, Nov 30, 2010 at 2:20

Re: [webkit-dev] Faster Git SVN updates

2010-11-30 Thread Eric Seidel
I'm not sure git can be the default way to checkout webkit until it's installed on the default Mac OS X install. :) -eric On Tue, Nov 30, 2010 at 3:07 PM, Ojan Vafai o...@chromium.org wrote: On Tue, Nov 30, 2010 at 2:59 PM, Eric Seidel e...@webkit.org wrote: I think it's time that we

Re: [webkit-dev] Faster Git SVN updates

2010-11-30 Thread Dirk Pranke
Really? XCode isn't installed on the default Mac OS X install. I mean, sure, the easier it is to get started and all, but that's hardly a big hurdle. -- Dirk On Tue, Nov 30, 2010 at 3:15 PM, Eric Seidel e...@webkit.org wrote: I'm not sure git can be the default way to checkout webkit until it's

Re: [webkit-dev] Faster Git SVN updates

2010-11-30 Thread Ojan Vafai
For the record, I was just suggesting that http://webkit.org/building/checkout.html should have instructions for using both git and svn. On Tue, Nov 30, 2010 at 3:51 PM, Dirk Pranke dpra...@chromium.org wrote: Really? XCode isn't installed on the default Mac OS X install. I mean, sure, the