I've been looking for ways to improve the hackability of WebCore, and
one thing that's been bothering me is the organization of our files.
It seems like we're due for a bit of fall cleaning for directories.
We've talked about some of these ideas before, but I wanted to put
them all in one email so
What's the benefit of this re-org?
Is it really worth the trouble to move these files around? This would mean
that we may need to navigate multiple pages on trac to see revision logs.
Other tools may suffer from such file moves as well. I remember I had to
create new git checkout when Source move
I also agree with moving Platform out. That would make the
dependencies easier to understand and hopefully avoid more layering
violations.
Kenneth
On Fri, Nov 18, 2011 at 11:06 AM, Ryosuke Niwa rn...@webkit.org wrote:
What's the benefit of this re-org?
Is it really worth the trouble to move
SGTM.
manual-tests is a no-brainer for sure.
On Fri, Nov 18, 2011 at 1:51 AM, Adam Barth aba...@webkit.org wrote:
I've been looking for ways to improve the hackability of WebCore, and
one thing that's been bothering me is the organization of our files.
It seems like we're due for a bit of
I agree. My personal favorite is the moving out of the side-loaded
features. This looks like a great way to add clarity to what WebCore
really means.
:DG
On Fri, Nov 18, 2011 at 2:19 AM, Eric Seidel e...@webkit.org wrote:
SGTM.
manual-tests is a no-brainer for sure.
On Fri, Nov 18, 2011 at
On Nov 18, 2011, at 1:51 AM, Adam Barth wrote:
Features/ -- New folder for (roughly) self-contained features
I like the concept, but not the name. I’ll try to think on this and suggest a
name I like better than “features”.
notifications/
storage/
fileapi/
webaudio/
mediastream/
The bot step that runs ui_tests uses scripts/slave/runtest.py. You could
probably set PATH in that script before launching ui_tests.
http://build.chromium.org/p/chromium/builders/Mac10.5%20Tests%20%282%29/builds/10395/steps/ui_tests/logs/stdio
With the recently landed changes in http://trac.webkit.org/changeset/100510
(and two subsequent fixes in http://trac.webkit.org/changeset/100523 and
http://trac.webkit.org/changeset/100729), strings in JavaScriptCore are
stored internally in either 8 bit or 16 bit forms. This is implemented in
On Nov 18, 2011, at 2:14 PM, Michael Saboff wrote:
Although the UChar* characters() method for the various string classes still
works, all new code should check what flavor a string is constructed by
using the new is8Bit() method on the various string classes. After
determining the
On Fri, Nov 18, 2011 at 2:06 AM, Ryosuke Niwa rn...@webkit.org
wrote: What's the benefit of this re-org?
The benefit is mostly to improve the hackability of WebKit by grouping
related code together and separating unrelated code. My hope is that
the code in the Features directory will become more
On Nov 18, 2011, at 11:18 AM, Adam Roben wrote:
On Nov 18, 2011, at 2:14 PM, Michael Saboff wrote:
Although the UChar* characters() method for the various string classes still
works, all new code should check what flavor a string is constructed by
using the new is8Bit() method on the
Hi all-
Darin Adler's been helping me sift through the leaks we're seeing on the Lion
Intel Leaks bot. (You can see the results of a recent run here:
http://build.webkit.org/LeaksViewer/?url=%2Fresults%2FLion%20Intel%20Leaks%2Fr100768%20%28193%29%2F.)
We could use some expert advice for two of
On Fri, Nov 18, 2011 at 1:51 AM, Adam Barth aba...@webkit.org wrote:
I've been looking for ways to improve the hackability of WebCore, and
one thing that's been bothering me is the organization of our files.
It seems like we're due for a bit of fall cleaning for directories.
We've talked about
On Fri, Nov 18, 2011 at 11:21 AM, Adam Barth aba...@webkit.org wrote:
On Fri, Nov 18, 2011 at 2:06 AM, Ryosuke Niwa rn...@webkit.org wrote:
What's the benefit of this re-org?
The benefit is mostly to improve the hackability of WebKit by grouping
related code together and separating
On Fri, Nov 18, 2011 at 11:21 AM, Adam Barth aba...@webkit.org wrote:
Features/
notifications/ (8 files)
storage/ (195 files)
fileapi/ (115 files)
webaudio/ (103 files)
mediastream/ (28 files; under active development)
workers/ (43 files)
websockets/ (20 files)
inspector/ (426
On Fri, Nov 18, 2011 at 1:47 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Fri, Nov 18, 2011 at 11:21 AM, Adam Barth aba...@webkit.org wrote:
On Fri, Nov 18, 2011 at 2:06 AM, Ryosuke Niwa rn...@webkit.org wrote:
What's the benefit of this re-org?
The benefit is mostly to improve the
On Fri, Nov 18, 2011 at 2:27 PM, Adam Barth aba...@webkit.org wrote:
On Fri, Nov 18, 2011 at 1:47 PM, Ryosuke Niwa rn...@webkit.org wrote:
Still, if I see a crash in shipped version of Chrome, then I have to
remember to map between different paths, which will be a huge cognitive
overhead
On Fri, Nov 18, 2011 at 2:38 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Fri, Nov 18, 2011 at 2:27 PM, Adam Barth aba...@webkit.org wrote:
We move files around all the time. If we're afraid to move files for
these reasons, we'll be stuck with bad organizational choices we made
in the
18 matches
Mail list logo
