Re: [webkit-dev] Reg. New File Inclusion Style for Webkit

2011-11-20 Thread Peter Kasting
On Sun, Nov 20, 2011 at 1:57 AM, Arunprasad Rajkumar ararunpra...@gmail.com wrote: Why don't we follow chrome style of file inclusions rather than the usual. For example, *#include WebCore/Page/Chrome.h* This will be more convient way of representing the inclusion. Hope it will avoid long

Re: [webkit-dev] Simplifying hub classes (was Cleaning up directories in WebCore)

2011-11-20 Thread Hajime Morrita
One traditional pattern is to split a big class into a set small classes plus a hub class like how Adam has done for original Frame. In that pattern, small classes has a reference to the hub class and know its API. I hope these small classes know just a small part of its hub class via interface

Re: [webkit-dev] Simplifying hub classes (was Cleaning up directories in WebCore)

2011-11-20 Thread Adam Barth
On Sun, Nov 20, 2011 at 8:36 PM, Hajime Morrita morr...@google.com wrote: One traditional pattern is to split a big class into  a set small classes plus a hub class like how Adam has done for original Frame. ^^^ The work to split up Frame was largely done before I was involved with the

[webkit-dev] Confusion over over-constrained case in RenderBox::computePositionedLogicalWidthUsing

2011-11-20 Thread Fady Samuel
Hi all, I'm currently studying layout code in RenderBox very carefully as I work on this: https://bugs.webkit.org/show_bug.cgi?id=47738 I'm a bit confused about something fairly subtle. In the overconstrained case where logical left, logical width, and logical right are all specified, we should

[webkit-dev] Adding ENABLE_STYLE_SCOPED for a while

2011-11-20 Thread Roland Steiner
Hi all, Since style scoped requires several patches to land fully, I intend to add a ENABLE_STYLE_SCOPED flag for a while to avoid potentially shipping half-done code. See https://bugs.webkit.org/show_bug.cgi?id=72848 for the flag, and https://bugs.webkit.org/show_bug.cgi?id=49142 for the master

[webkit-dev] WML build error

2011-11-20 Thread Nataraj Bukkambudi
Hi All, I Enabled the WML Flag in r84325 Webkit version in \WebKitLibraries\win\tools\vsprops\FeatureDefines, but it's giving error like \page\Frame.cpp(113) : fatal error C1083: Cannot open include file: 'WMLNames.h': No such file or directory. WMLNames.h file is not generating, but

Re: [webkit-dev] WML build error

2011-11-20 Thread Eric Seidel
WML has been removed. https://bugs.webkit.org/show_bug.cgi?id=59678 On Sun, Nov 20, 2011 at 11:17 PM, Nataraj Bukkambudi natarajb...@gmail.com wrote: Hi All, I Enabled the WML Flag in r84325 Webkit version in \WebKitLibraries\win\tools\vsprops\FeatureDefines, but it's giving error like

Re: [webkit-dev] WML build error

2011-11-20 Thread Nataraj Bukkambudi
Dear Eric Seidel, Yes WML Code removed from Webcore trunk from r85256, but we are using * r84325*. But r84325 Windows build is giving the below error for us by enabling WML flag. I m suspecting some changes went wrong in WebCore\dom\make_names.pl for generating .h files that is WMLNames.h.