Re: [webkit-dev] Initializing String and AtomicString with literals

2012-08-25 Thread Benjamin Poulain
On Fri, Aug 24, 2012 at 10:18 PM, Adam Barth aba...@webkit.org wrote: [[[ The difference between the version is if the length of the string is included or not. Having the size given in the constructor makes the constructor faster. Having the size also makes the code bigger, which is a

Re: [webkit-dev] Initializing String and AtomicString with literals

2012-08-25 Thread Benjamin Poulain
On Fri, Aug 24, 2012 at 10:05 PM, Adam Barth aba...@webkit.org wrote: Thanks! The wiki page is very helpful. I wonder if we should organize a hack-a-thon to deploy this pattern throughout WebKit. Is there a way the compiler could give us a list of all the code location we should update?

Re: [webkit-dev] [WK2] WebContext destructor is never triggered on normal exit

2012-08-25 Thread Sam Weinig
I'm not clear on what you mean. A client of WebKit2 release their WKContextRef pointer from atexit() if they wanted to (or in whatever other termination routines they already have), but its not clear to me why the framework should do it for them. We don't do this for any other objects. -Sam