Re: [webkit-dev] compile failure when I try to introduce GLContextEGL to MediaPlayerPrivateGStreamer

2012-11-09 Thread Simon Hausmann
On Friday, November 09, 2012 02:16:33 AM Zhao, Halley wrote: when using g++ -E, I found the issue after pre-processing: (thanks suggestion from Philippe) After include GLContextEGL.h, MediaPlayer::None changes to MediaPlayer::0L after pre-processing. Ah, that's a classic. It's a macro the X11

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

2012-11-09 Thread Rafael Brandao
I've just submitted a patch for this issue (bug 90823https://bugs.webkit.org/show_bug.cgi?id=90823). I'm also a shameless printfer and I believe the project could benefit with such debugging helpers. I've decided to isolate the debug definitions in a single place, so instead of adding alien code

Re: [webkit-dev] compile failure when I try to introduce GLContextEGL to MediaPlayerPrivateGStreamer

2012-11-09 Thread Darin Adler
On Nov 9, 2012, at 12:27 AM, Simon Hausmann simon.hausm...@digia.com wrote: It's the X11 headers that are broken and the usual workaround is to do things like #undef None after including them. That should probably happen in GLContextEGL.h or even nearer to the inclusion. I agree.

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

2012-11-09 Thread Rafael Brandao
You're right. Do you have any consensus of which approach is the best? I'd go with the overloads in a single file, as each one of them are likely inline, and this would make easier to add overloads. On Fri, Nov 9, 2012 at 2:33 PM, Maciej Stachowiak m...@apple.com wrote: You could either put

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

2012-11-09 Thread Darin Adler
On Nov 9, 2012, at 9:59 AM, Rafael Brandao rafael.l...@openbossa.org wrote: I'd go with the overloads in a single file Why? Seems the overloads should be in the files of the classes they are for. -- Darin ___ webkit-dev mailing list

[webkit-dev] Adding blending mode to WebKit canvas

2012-11-09 Thread Rik Cabanier
Hi, I'd like to add support for blending modes to Canvas. The spec for this feature can be found here: https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#canvascompositingandblending The implementation will be tracked by a meta bug: https://bugs.webkit.org/show_bug.cgi?id=100069 I