Re: [webkit-dev] Code cleaning: LEGACY_VIEWPORT_ADAPTION

2013-10-30 Thread Hugo Lima
On Tue, Oct 29, 2013 at 9:00 PM, Benjamin Poulain benja...@webkit.org wrote: Hi WebKit, Hi, I plan to remove the code guarded by LEGACY_VIEWPORT_ADAPTION and the flag itself. I was reading the original bug report[1] to find a list of websites targeting mobile devices that don't render well

[webkit-dev] Watchlist cc rules.

2013-10-30 Thread Samuel White
Hey everyone, I’d like to add myself to the “Accessibility” cc rule in the WebKit/Tools/Scripts/webkitpy/common/config/watchlist script. Should I simply file a bug and attach a patch as usual, or does touching this area involve a different procedure (since it’s not really a bug)? Thanks for

Re: [webkit-dev] Watchlist cc rules.

2013-10-30 Thread Zoltan Horvath
Hi Sam, You should file a bug with a patch for doing this. Cheers, Zoltan On Wed, Oct 30, 2013 at 10:06 AM, Samuel White samuel_wh...@apple.comwrote: Hey everyone, I’d like to add myself to the “Accessibility” cc rule in the WebKit/Tools/Scripts/webkitpy/common/config/watchlist script.

Re: [webkit-dev] Watchlist cc rules.

2013-10-30 Thread Osztrogonác Csaba
Hi, I don't agree with Zoltán. Adding yourself to the watchlist doesn't need bug report and review. You are a committer, you can simple add yourself to the watchlist directly as others did it in the past. But you should run test-webkitpy tests before committing to make sure you don't break

Re: [webkit-dev] Code cleaning: LEGACY_VIEWPORT_ADAPTION

2013-10-30 Thread Benjamin Poulain
On 10/30/13, 7:44 AM, Hugo Lima wrote: On Tue, Oct 29, 2013 at 9:00 PM, Benjamin Poulain benja...@webkit.org wrote: I plan to remove the code guarded by LEGACY_VIEWPORT_ADAPTION and the flag itself. I was reading the original bug report[1] to find a list of websites targeting mobile devices

Re: [webkit-dev] Watchlist cc rules.

2013-10-30 Thread Ryosuke Niwa
Yeah, we've historically added people to the watchlist without reviews. So file a bug upload a patch only if you're not a committer. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev