Re: [webkit-dev] On web-exposing features disabled at runtime

2014-02-14 Thread Sergio Villar Senin
En 11/02/14 21:04, Maciej Stachowiak escribiu: Why not enabling the feature entirely on trunk? (and disable it when shipping product by disabling the compile time flag?). I think feature doing that tends to become stable a lot quicker. Occasionally a feature is so experimental you don't

[webkit-dev] Credit change set author when merging changes

2014-02-14 Thread Ryosuke Niwa
Hi, This is a friendly remainder that you should credit the original author and the relevant change set in blink when you're merging patches written by another author. e.g. http://trac.webkit.org/changeset/163528 - R. Niwa ___ webkit-dev mailing list

Re: [webkit-dev] Credit change set author when merging changes

2014-02-14 Thread Gyuyoung Kim
Hi, When we merge own blink patch into WebKit, should we credit the original author in ChangeLog ? Gyuyoung On Fri, Feb 14, 2014 at 5:36 PM, Ryosuke Niwa rn...@webkit.org wrote: Hi, This is a friendly remainder that you should credit the original author and the relevant change set in

[webkit-dev] Proposal: Datalist support for text input field.

2014-02-14 Thread ChangSeok Oh
Hi Webkitten. I'd like to bring datalist support to text field. To do that, I spent some time and made an initial patch. You can check it out here https://bugs.webkit.org/show_bug.cgi?id=98934 I haven't received any feedback from any reviewer unfortunately even though several weeks are passed

Re: [webkit-dev] Credit change set author when merging changes

2014-02-14 Thread Sergio Villar Senin
En 14/02/14 10:09, Gyuyoung Kim escribiu: Hi, When we merge own blink patch into WebKit, should we credit the original author in ChangeLog ? In those cases I don't personally do that. BR ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Credit change set author when merging changes

2014-02-14 Thread Andreas Kling
On Feb 14, 2014, at 1:38 AM, Sergio Villar Senin svil...@igalia.com wrote: En 14/02/14 10:09, Gyuyoung Kim escribiu: Hi, When we merge own blink patch into WebKit, should we credit the original author in ChangeLog ? In those cases I don't personally do that. Right. There is no need to

Re: [webkit-dev] Sergio Villar Senin is now a WebKit reviewer!

2014-02-14 Thread Mario Sanchez Prada
Well deserved. Congratulations! Mario -Original Message- From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev- boun...@lists.webkit.org] On Behalf Of Philippe Normand Sent: 12 February 2014 23:20 To: WebKit Development Subject: [webkit-dev] Sergio Villar Senin is now a

Re: [webkit-dev] Credit change set author when merging changes

2014-02-14 Thread Osztrogonác Csaba
Hi, I checked the history of blink merges, but I haven't found too much credit for the original author, but much more references to the commit similar to the changeset you mentioned. Should we mention the author _and_ the changeset too in the future? Ossy On 02/14/2014 09:36 AM, Ryosuke Niwa

Re: [webkit-dev] Credit change set author when merging changes

2014-02-14 Thread Ryosuke Niwa
I don't think you need the author's name if you include an URL to the relevant SVN or Git commit log since anyone could simply follow the URL to find the original author. It might be a nice gesture though. On the other hand, if we're simply mentioning a revision number without URL, then we

Re: [webkit-dev] On web-exposing features disabled at runtime

2014-02-14 Thread Dean Jackson
On 14 Feb 2014, at 12:17 am, Sergio Villar Senin svil...@igalia.com wrote: En 11/02/14 21:04, Maciej Stachowiak escribiu: Why not enabling the feature entirely on trunk? (and disable it when shipping product by disabling the compile time flag?). I think feature doing that tends to become

Re: [webkit-dev] Credit change set author when merging changes

2014-02-14 Thread Gyuyoung Kim
Thank you for you guys clarification. Let me follow that from now. Gyuyoung. 2014년 2월 14일 금요일, Ryosuke Niwarn...@webkit.org님이 작성한 메시지: I don't think you need the author's name if you include an URL to the relevant SVN or Git commit log since anyone could simply follow the URL to find the