[webkit-dev] Update: Cygwin Recommendations for Windows Builders

Hi folks, Yesterday I documented a few problems I was having with Cygwin, and asked if anyone else was encountering any issues. Since then, I’ve figured out what was going on, and I wanted to post a follow-up to document my findings. I’ll also be updating our Wiki page on the topic (

Re: [webkit-dev] Adding flag to optionally run check-webkit-style as part of prepare-Changelog and svn-create-patch

Sounds good to me. Thanks, James. On Fri, Apr 4, 2014 at 2:51 PM, James Craig wrote: > On Apr 4, 2014, at 1:33 PM, Zoltan Horvath wrote: > > > On Fri, Apr 4, 2014 at 12:43 PM, James Craig wrote: > > > >> On Apr 4, 2014, at 9:08 AM, Zoltan Horvath wrote: > >> > >>> Hi there, > >>> > >>> pr

Re: [webkit-dev] Adding flag to optionally run check-webkit-style as part of prepare-Changelog and svn-create-patch

On Apr 4, 2014, at 1:33 PM, Zoltan Horvath wrote: > On Fri, Apr 4, 2014 at 12:43 PM, James Craig wrote: > >> On Apr 4, 2014, at 9:08 AM, Zoltan Horvath wrote: >> >>> Hi there, >>> >>> prepare-Changelog: >>> - The style checker script runs on the ChangeLogs as well, and it gives >>> warning

Re: [webkit-dev] Adding flag to optionally run check-webkit-style as part of prepare-Changelog and svn-create-patch

04 апр. 2014 г., в 9:08, Zoltan Horvath написал(а): > - I think the best behavior for this case would be to abort the change log > creation, if there are errors on the actual code check. (Then you can fix > those, and when you rerun prepare-Changelog, it puts the recent things into > the cha

Re: [webkit-dev] Adding flag to optionally run check-webkit-style as part of prepare-Changelog and svn-create-patch

On Fri, Apr 4, 2014 at 12:43 PM, James Craig wrote: > > On Apr 4, 2014, at 9:08 AM, Zoltan Horvath wrote: > > Hi there, > > prepare-Changelog: > - The style checker script runs on the ChangeLogs as well, and it gives > warning if the bug number or the tests' line are not filled. > > > I conside

Re: [webkit-dev] Adding flag to optionally run check-webkit-style as part of prepare-Changelog and svn-create-patch

On Apr 4, 2014, at 9:08 AM, Zoltan Horvath wrote: > Hi there, > > prepare-Changelog: > - The style checker script runs on the ChangeLogs as well, and it gives > warning if the bug number or the tests' line are not filled. I consider this an expected behavior. If you don't include --bug=12345

Re: [webkit-dev] Adding flag to optionally run check-webkit-style as part of prepare-Changelog and svn-create-patch

Hi there, prepare-Changelog: - The style checker script runs on the ChangeLogs as well, and it gives warning if the bug number or the tests' line are not filled. - I think the best behavior for this case would be to abort the change log creation, if there are errors on the actual code check. (Th

Re: [webkit-dev] Adding flag to optionally run check-webkit-style as part of prepare-Changelog and svn-create-patch

Yes, but not everyone uses the webkit-patch script in their workflow. > On Apr 4, 2014, at 7:27 AM, Brendan Long wrote: > > Doesn't 'webkit-patch upload' already do that? > >> On 04/04/2014 02:14 AM, James Craig wrote: >> I sometimes forget to run the check-webkit-style script before uploading

Re: [webkit-dev] Adding flag to optionally run check-webkit-style as part of prepare-Changelog and svn-create-patch

Doesn't 'webkit-patch upload' already do that? On 04/04/2014 02:14 AM, James Craig wrote: I sometimes forget to run the check-webkit-style script before uploading patches, so I put a patch up for review that adds a --style and --no-style flags to prepare-Changelog and svn-create-patch. Alexey

[webkit-dev] Adding flag to optionally run check-webkit-style as part of prepare-Changelog and svn-create-patch

I sometimes forget to run the check-webkit-style script before uploading patches, so I put a patch up for review that adds a --style and --no-style flags to prepare-Changelog and svn-create-patch. Alexey suggested I make it the default, which I've done for prepare-Changelog, but not in svn-crea