[webkit-dev] Removing CUSTOM_PROTOCOLS compile guard?

2014-10-14 Thread Pascal Jacquemart
Hi, I was wondering if we could remove the CUSTOM_PROTOCOLS compile guard? I believe this is the default code path for all ports now since we moved EFL to use it last week https://bugs.webkit.org/show_bug.cgi?id=128177 At least, it is mandatory for GTK and EFL builds, I don't know much about

Re: [webkit-dev] [webkit-qt] Qt 5.2.1 / 5.3.2 with JIT_ENABLED=0: Assert / Crash in LLIntData.cpp; Windows 7 x64

2014-10-14 Thread Allan Sandfeld Jensen
Hi again Andre I am learning towards the assert being right. It appears sub-classes will be placed on 64bit aligned address on Win x64. This breaks some assumptions on how arrays are layed out. I will have to check where we make use if the assumptions asserted here, and see how bad it is.

Re: [webkit-dev] Removing CUSTOM_PROTOCOLS compile guard?

2014-10-14 Thread Darin Adler
On Oct 14, 2014, at 3:25 AM, Pascal Jacquemart p.jacquem...@samsung.com wrote: At least, it is mandatory for GTK and EFL builds, I don't know much about other ports What file turns this on for GTK builds? I see it set in cmake/OptionsEfl.cmake for the EFL port, and in

Re: [webkit-dev] Removing CUSTOM_PROTOCOLS compile guard?

2014-10-14 Thread Martin Robinson
On Tue, Oct 14, 2014 at 9:29 AM, Darin Adler da...@apple.com wrote: What file turns this on for GTK builds? I see it set in cmake/OptionsEfl.cmake for the EFL port, and in WebKit2/WebKit2Prefix.h for the Mac and iOS ports. Like the Mac and iOS ports, this is enabled via