On Thu, May 24, 2018, 21:40 youenn fablet wrote:
>
>
>>> Ryosuke, correct me if I am wrong, I think you are pointing out the
>>> following rule:
>>> Changes to LayoutTests/imported/w3c/web-platform-tests tests should land
>>> first in WPT repository, then in WebKit repository.
>>>
>>
>> Oh, that
On Thu, May 24, 2018 at 9:27 PM, Frédéric Wang wrote:
> Thank you everybody for your replies. So summarizing:
>
> * WebKit devs should be able to choose between:
> - submitting new WPT tests to the GitHub WPT repo first and then
> importing them to the WebKit repo after they are approved.
> -
On 25/05/2018 00:52, Ryosuke Niwa wrote:
>
> Yes, it's okay for a WebKit commit to merge the change which got
> merged into WPT but it's never okay to first commit the test into
> WebKit and then later upstream it to WPT...
If that's what you meant by "NEVER commit new tests into
LayoutTests/import
Thank you everybody for your replies. So summarizing:
* WebKit devs should be able to choose between:
- submitting new WPT tests to the GitHub WPT repo first and then
importing them to the WebKit repo after they are approved.
- OR submitting patches to WebKit Bugzilla first and then exporting
On Thu, May 24, 2018 at 3:22 AM, Philip Jägenstedt
wrote:
> On Wed, May 23, 2018, 23:43 youenn fablet wrote:
>
>> Le mer. 23 mai 2018 à 14:11, Frédéric Wang a écrit :
>>
>>> On 23/05/2018 22:50, Ryosuke Niwa wrote:
>>> > As we have preciously discussed, we should NEVER commit new tests into
>>>
>
>> Ryosuke, correct me if I am wrong, I think you are pointing out the
>> following rule:
>> Changes to LayoutTests/imported/w3c/web-platform-tests tests should land
>> first in WPT repository, then in WebKit repository.
>>
>
> Oh, that is surprising.
>
> https://github.com/w3c/web-platform-tests
On Wed, May 23, 2018, 23:43 youenn fablet wrote:
> Le mer. 23 mai 2018 à 14:11, Frédéric Wang a écrit :
>
>> On 23/05/2018 22:50, Ryosuke Niwa wrote:
>> > As we have preciously discussed, we should NEVER commit new tests into
>> > LayoutTests/imported/w3c/web-platform-tests.
>>
>
> Ryosuke, corr
7 matches
Mail list logo