Re: [webkit-dev] Remove HAVE_ACCESSIBILITY

2018-11-14 Thread Michael Catanzaro
On Wed, Nov 14, 2018 at 7:49 PM, Fujii Hironori wrote: No, it isn't high. It is no problem to keep the code. CMake defines the similar name macro ENABLE_ACCESSIBILITY=0 in generated cmakeconfig.h. https://trac.webkit.org/browser/webkit/trunk/Source/cmake/WebKitFeatures.cmake#L88 This c

Re: [webkit-dev] Remove HAVE_ACCESSIBILITY

2018-11-14 Thread Fujii Hironori
On Thu, Nov 15, 2018 at 12:05 PM Timothy Hatcher wrote: > It wasn’t added for Tesla. But they did build with it disabled at the time > I lasted worked on it. It was a frequent pain point to keep the build > working when AX changes happened. > > For the record, HAVE_ACCESSIBILITY has been introdu

Re: [webkit-dev] Remove HAVE_ACCESSIBILITY

2018-11-14 Thread Timothy Hatcher
It wasn’t added for Tesla. But they did build with it disabled at the time I lasted worked on it. It was a frequent pain point to keep the build working when AX changes happened. — Timothy Hatcher > On Nov 14, 2018, at 5:29 PM, Ryosuke Niwa wrote: > > I think it was added for Telsa's private

Re: [webkit-dev] Remove HAVE_ACCESSIBILITY

2018-11-14 Thread Fujii Hironori
On Thu, Nov 15, 2018 at 10:29 AM Ryosuke Niwa wrote: > I think it was added for Telsa's private port. Probably not worth > maintaining the flag if the maintenance cost is high but is it? > No, it isn't high. It is no problem to keep the code. CMake defines the similar name macro ENABLE_ACCESSI

Re: [webkit-dev] Remove HAVE_ACCESSIBILITY

2018-11-14 Thread Ryosuke Niwa
I think it was added for Telsa's private port. Probably not worth maintaining the flag if the maintenance cost is high but is it? - R. Niwa On Wed, Nov 14, 2018 at 5:19 PM Fujii Hironori wrote: > Hi webkit-dev, > > It seems that all port defines HAVE_ACCESSIBILITY=1. Can I remove all code > for

[webkit-dev] Remove HAVE_ACCESSIBILITY

2018-11-14 Thread Fujii Hironori
Hi webkit-dev, It seems that all port defines HAVE_ACCESSIBILITY=1. Can I remove all code for !HAVE(ACCESSIBILITY)? https://trac.webkit.org/browser/webkit/trunk/Source/WTF/wtf/Platform.h?rev=237992#L648 #if PLATFORM(COCOA) || PLATFORM(WIN) || PLATFORM(GTK) || PLATFORM(WPE) #define HAVE_ACCES

Re: [webkit-dev] [CSSOM View] Smooth scroll behavior via CSS property / DOM scroll* API

2018-11-14 Thread Frédéric Wang
Hi all, The main implementation is now submitted for review at: https://bugs.webkit.org/show_bug.cgi?id=188043 It has some issue with smooth scrolling via scrollIntoView on nested scrollers but I don't plan to work on this until the main part is merged. See https://bugs.webkit.org/show_bug.cgi?id