Re: [webkit-dev] Introducing WTF::makeUnique and WTF::makeUniqueWithoutFastMallocCheck

2019-08-23 Thread Alex Christensen
This may be a tangent, but I wouldn’t mind replacing our use of std::unique_ptr with a smart pointer with "const T* get() const” and “T* get()” instead of std::unique_ptr’s “T* get() const”. I think that would help us write more const-correct code. > On Aug 23, 2019, at 9:10 AM, Darin Adler w

Re: [webkit-dev] Introducing WTF::makeUnique and WTF::makeUniqueWithoutFastMallocCheck

2019-08-23 Thread Darin Adler
> On Aug 23, 2019, at 7:26 AM, Antti Koivisto wrote: > > Could WTF::makeUnique simply use FastMalloc by default? We could then remove > most of these messy annotations. > > This would require replacing std::unique_ptr with a type that knows how to > free the objects correctly (bring back OwnPt

Re: [webkit-dev] Introducing WTF::makeUnique and WTF::makeUniqueWithoutFastMallocCheck

2019-08-23 Thread Antti Koivisto
On Mon, Aug 19, 2019 at 10:25 AM Yusuke Suzuki wrote: > Hello WebKit folks! > > I would like to announce that I’ve just landed the patch which introduces > `WTF::makeUnique` and `WTF::makeUniqueWithoutFastMallocCheck` in > https://trac.webkit.org/changeset/248846. > They are drop-in-replacement t