Re: [webkit-dev] Let's use -Werror on EWS?

2021-05-24 Thread Darin Adler via webkit-dev
Sorry, I should clarify. Apple’s ports of WebKit already use -Werror and always have, everywhere, not just on EWS. Since day one. I do not know why we do not already use -Werror on GTK and WPE and I support using it there after fixing all the warnings. — Darin

Re: [webkit-dev] Let's use -Werror on EWS?

2021-05-24 Thread Darin Adler via webkit-dev
I’m a big fan of -Werror. Back when WebKit started, it was controversial to use it at Apple. But we can’t just turn on -Werror until after we fix all the warnings! Who will do that project. — Darin ___ webkit-dev mailing list

Re: [webkit-dev] Let's use -Werror on EWS?

2021-05-24 Thread Michael Catanzaro via webkit-dev
On Mon, May 24 2021 at 05:42:37 PM -0500, Michael Catanzaro wrote: But really, rather than cherry-picking particular warning flags, using -Werror seems simplest to me. Problematic warnings should be disabled or suppressed. We might want to globally suppress -Warray-bounds and -Wnonnull when

[webkit-dev] Let's use -Werror on EWS?

2021-05-24 Thread Michael Catanzaro via webkit-dev
Hi, I'd like to suggest turning on -Werror on at least the GTK and WPE EWS, to reduce the amount of time I spend cleaning up newly-introduced build warnings. ;) If we're worried about too many spurious build failures, let's at least build with a few flags to prevent the most common GCC