Re: [webkit-dev] Fuzzy Reftest Plans, and Metadata Locations

2021-10-29 Thread Myles Maxfield via webkit-dev
> On Oct 28, 2021, at 10:24 AM, Sam Sneddon via webkit-dev > wrote: > > Hi! > > As part of the ongoing work on GPU Process, we’re interested in adding > support for reftest fuzzy matching (i.e., allowing a certain amount of > tolerance when comparing the generated images). > > Our intentio

Re: [webkit-dev] -Wreturn-type and -Wredundant-move reminders

2021-10-29 Thread Michael Catanzaro via webkit-dev
On Fri, Oct 29 2021 at 03:06:17 PM -0700, Myles Maxfield wrote: Will GTK/WPE EWS catch these errors? Currently no, but they will once we solve https://bugs.webkit.org/show_bug.cgi?id=155047. ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] -Wreturn-type and -Wredundant-move reminders

2021-10-29 Thread Myles Maxfield via webkit-dev
> On Oct 19, 2021, at 1:15 PM, Michael Catanzaro via webkit-dev > wrote: > > Hi devs, > > A reminder about this common idiom: > > switch (...) { > case Foo: > return ...; > case Bar: > return ...; > } > RELEASE_ASSERT_NOT_REACHED(); > > When it's intended that the code always returns i