Re: [webkit-dev] Compile times and class-scoped enums

2023-01-23 Thread Jer Noble via webkit-dev
> On Jan 23, 2023, at 11:05 AM, Geoffrey Garen wrote: > >>> However, this change requires moving class-scoped enums out into the >>> namespace scope. >> >> Seems worthwhile. Doesn’t seem to me like it would have far reaching effects. > > I agree. > >> +using Type = DOMAudioSessionType;

Re: [webkit-dev] Stop Using Raw Pointers & References in New Code

2023-01-23 Thread Geoffrey Garen via webkit-dev
Is the idea that a checker failure should block landing a patch, or just that it should start a conversation with your patch reviewer about why this case is an exception? Maybe the ’should’ clause in the error message could clarify. In general, I do think it’s helpful to flag any new raw

Re: [webkit-dev] Compile times and class-scoped enums

2023-01-23 Thread Geoffrey Garen via webkit-dev
>> However, this change requires moving class-scoped enums out into the >> namespace scope. > > Seems worthwhile. Doesn’t seem to me like it would have far reaching effects. I agree. > +using Type = DOMAudioSessionType; Did you do this to make the patch smaller, or do you prefer this