Re: [webkit-dev] Can we remove Notification.show()?

2013-02-07 Thread Andrew Wilson
') and it displayed a notification, so it doesn't seem like show() is necessary in more recent versions of WebKit. On Thu, Feb 7, 2013 at 1:51 PM, Claudio Saavedra csaave...@igalia.comwrote: On Mon, 2013-01-28 at 10:35 +0100, Andrew Wilson wrote: So, we've recently landed some fixes to address permissions

[webkit-dev] Can we remove Notification.show()?

2013-01-28 Thread Andrew Wilson
So, we've recently landed some fixes to address permissions handling for Notification.show(): http://trac.webkit.org/changeset/140927 Turns out, the notifications specification does not have a show() API (the notification is automatically shown from the constructor --

Re: [webkit-dev] Can we remove Notification.show()?

2013-01-28 Thread Andrew Wilson
On Mon, Jan 28, 2013 at 11:53 AM, Jon Lee jon...@apple.com wrote: Also, it looks like if a platform enables ENABLE_LEGACY_NOTIFICATIONs, not only do they get support for the old webkitNotifications API, but also some of the old API (like show() and cancel()) is exposed on the new

Re: [webkit-dev] Followup on removing webkitNotifications.createHTMLNotification

2013-01-23 Thread Andrew Wilson
Hmmm. Does FeatureObserver detect features invoked from web apps like Gmail? Because I'm fairly certain that Gmail and Google Calendar still use webkitNotifications for their notifications. Not to say that we shouldn't land this patch anyway - just pointing out that this may still be used more

Re: [webkit-dev] Followup on removing webkitNotifications.createHTMLNotification

2013-01-23 Thread Andrew Wilson
On Wed, Jan 23, 2013 at 9:58 AM, Adam Barth aba...@webkit.org wrote: On Wed, Jan 23, 2013 at 12:45 AM, Andrew Wilson atwil...@google.com wrote: Hmmm. Does FeatureObserver detect features invoked from web apps like Gmail? Yes. Because I'm fairly certain that Gmail and Google Calendar still

Re: [webkit-dev] Changes to window.focus/window.blur controlled by a setting?

2012-05-21 Thread Andrew Wilson
On Mon, May 21, 2012 at 2:17 AM, Jochen Eisinger joc...@chromium.orgwrote: Hey, in https://bugs.webkit.org/show_bug.cgi?id=86969 I'm changing window.focus and window.blur to match Firefox's behavior: window.blur does nothing, and window.focus only works when invoked from the window that

Re: [webkit-dev] Changes to window.focus/window.blur controlled by a setting?

2012-05-21 Thread Andrew Wilson
On Mon, May 21, 2012 at 12:21 PM, Maciej Stachowiak m...@apple.com wrote: On May 21, 2012, at 12:16 PM, Andrew Wilson atwil...@google.com wrote: On Mon, May 21, 2012 at 2:17 AM, Jochen Eisinger joc...@chromium.orgwrote: Hey, in https://bugs.webkit.org/show_bug.cgi?id=86969 I'm changing

Re: [webkit-dev] Changes to window.focus/window.blur controlled by a setting?

2012-05-21 Thread Andrew Wilson
On Mon, May 21, 2012 at 12:21 PM, Jochen Eisinger joc...@chromium.orgwrote: On Mon, May 21, 2012 at 9:16 PM, Andrew Wilson atwil...@google.comwrote: On Mon, May 21, 2012 at 2:17 AM, Jochen Eisinger joc...@chromium.orgwrote: Hey, in https://bugs.webkit.org/show_bug.cgi?id=86969 I'm

Re: [webkit-dev] Web Notifications API

2012-02-15 Thread Andrew Wilson
On Wed, Feb 15, 2012 at 6:12 PM, Jian Li jia...@chromium.org wrote: On Wed, Feb 15, 2012 at 9:46 AM, Jon Lee jon...@apple.com wrote: On Feb 13, 2012, at 5:51 PM, Andrew Wilson atwil...@google.com wrote: I don't have an answer for you here, as the internet is vast :) Among google

Re: [webkit-dev] Propose adding button support to text based notifications (Was: Removing HTML notifications from WebKit)

2012-02-14 Thread Andrew Wilson
On Tue, Feb 14, 2012 at 6:13 PM, Benjamin Poulain benja...@webkit.orgwrote: On Tue, Feb 14, 2012 at 5:59 PM, Jian Li jia...@chromium.org wrote: One of the reasons for using html notifications is to allow direct interaction with the notifications. Here're some scenarios from our customers

Re: [webkit-dev] Web Notifications API

2012-02-13 Thread Andrew Wilson
in a nag sheet, making for a bad user experience. I think it makes sense to keep the permissions mechanism confined to the needs of notifications. Andrew Wilson wrote: One note: if we're going to change the API at all, I'd like to see us change it exactly once - to the draft API defined

Re: [webkit-dev] Web Notifications API

2012-02-09 Thread Andrew Wilson
On Wed, Feb 8, 2012 at 4:58 PM, Jon Lee jon...@apple.com wrote: Hi WebKit! I am interested in refactoring the API for web notifications, and would like your feedback. We are working on getting permission to join the Web Notifications working group, but thought that while doing that I could

Re: [webkit-dev] Web Notifications API

2012-02-09 Thread Andrew Wilson
On Thu, Feb 9, 2012 at 9:53 AM, Jon Lee jon...@apple.com wrote: On Feb 8, 2012, at 5:41 PM, John Gregg wrote: 3. Use static functions on the notification constructor for permissions checks. By moving them there, it allows us to remove window.webkitNotifications and the NotificationCenter