Re: [webkit-dev] Caio Lima is now a WebKit reviewer

2021-03-19 Thread Caio Lima via webkit-dev
> > On Mar 18, 2021, at 3:42 PM, Saam Barati via webkit-dev >> > wrote: >> > >> > Hi folks, >> > >> > I'm happy to announce that Caio Lima is now a WebKit reviewer. Send your >> > JavaScriptCore reviews his way! >> &g

Re: [webkit-dev] Adrian Perez de Castro is now a WebKit reviewer

2019-10-14 Thread Caio Lima
Congratulations Adrian! Em seg, 14 de out de 2019 às 15:17, Carlos Alberto Lopez Perez < clo...@igalia.com> escreveu: > Hi everyone, > > I would like to announce that Adrian Perez de Castro (aperezdc on #webkit) > is now a WebKit reviewer. > > Adrian has several years of experience working with t

Re: [webkit-dev] JSC EWS being too optimistic

2019-10-09 Thread Caio Lima
sion from a > recent change. > > I verified the fix using the same patch you tested with earlier. jsc EWS is > now (correctly) failing on that patch > (https://bugs.webkit.org/show_bug.cgi?id=202140). Please let me know if you > notice any issue. > > Thanks > Aakash &

[webkit-dev] JSC EWS being too optimistic

2019-10-03 Thread Caio Lima
27;s radar?If not, could anybody take a look on this? I tried to investigate, but I'm lacking knowledge of EWS code base. This already caused some noise into JSC patches that broke ARMv7 and MIPS ports. I opened this bug to report it https://bugs.webkit.org/show_bug.cgi?id=202419. Thanks i

Re: [webkit-dev] Work on new JS language features

2019-07-09 Thread Caio Lima
Up on this thread. Em seg, 1 de jul de 2019 às 13:19, Caio Lima escreveu: > > Hi WebKittens, > > As some of you may know, my colleagues from Igalia have been working > to implement new {Java|ECMA}Script language features in > JavaScriptCore, including BigInt and Class Fie

[webkit-dev] Work on new JS language features

2019-07-01 Thread Caio Lima
Hi WebKittens, As some of you may know, my colleagues from Igalia have been working to implement new {Java|ECMA}Script language features in JavaScriptCore, including BigInt and Class Fields. We have a number of Class Fields patches awaiting review: - Instance Class Fields (https://bugs.webki

Re: [webkit-dev] Tadeu and Robin are now WebKit reviewers

2019-06-11 Thread Caio Lima
Congratulations! Em ter, 11 de jun de 2019 às 05:13, Filip Pizlo escreveu: > Congrats! > > -Filip > > > On Jun 10, 2019, at 6:10 PM, Yusuke Suzuki wrote: > > > > Congrats! :D > > > >> On Jun 10, 2019, at 3:49 PM, Saam Barati wrote: > >> > >> Hi folks, > >> > >> Tadeu and Robin are both now Web

Re: [webkit-dev] Don Olmstead and Ross Kirsling are now WebKit reviewers

2018-12-13 Thread Caio Lima
Congratulations! Em qui, 13 de dez de 2018 às 20:08, Brian Burg escreveu: > Congrats everyone! > > > On Dec 13, 2018, at 1:46 PM, Fujii Hironori > wrote: > > Hi everyone, > > I would like to announce that Don Olmstead (dolmstead on #webkit) and > Ross Kirsling (rkirsling) are now WebKit reviewe

Re: [webkit-dev] BigIntBench

2018-10-09 Thread Caio Lima
Hi Saam. Em seg, 8 de out de 2018 às 02:41, Saam Barati escreveu: > > Hi Caio, > > > On Oct 6, 2018, at 7:30 AM, Caio Lima wrote: > > > > Hi all. > > > > I'm starting working to fix JIT support of BigInt in some operations > > we already h

[webkit-dev] BigIntBench

2018-10-06 Thread Caio Lima
Hi all. I'm starting working to fix JIT support of BigInt in some operations we already have upstream. In such case, I'm sending (https://bugs.webkit.org/show_bug.cgi?id=186177) to support BigInt speculation into ValueAdd node. As I want to know if BigInt speculation represents some performance im

Re: [webkit-dev] Ask for review in BigInt Patch

2018-04-23 Thread Caio Lima
/show_bug.cgi?id=184474 Some of these patches are blocking others like the addition and subtraction operations (https://bugs.webkit.org/show_bug.cgi?id=179002) and mod operation (https://bugs.webkit.org/show_bug.cgi?id=184327). Best regards, Caio. 2018-04-17 23:52 GMT-03:00 Caio Lima : > Hi all. > &

Re: [webkit-dev] Ask for review in BigInt Patch

2018-04-17 Thread Caio Lima
gi?id=183996 Could anyone take a look on these bugs? Regards, Caio. 2018-03-19 4:36 GMT-03:00 Caio Lima : > Hi all. > > It's been a while I am asking for review into BigInt Patches but get > no answer. I have 4 Patches in the queue to be reviewed but some of > them are depe

Re: [webkit-dev] Ask for review in BigInt Patch

2018-03-19 Thread Caio Lima
d=182470) is the one that should be reviewed first. Is there any better approach of how I could get review on them? It is starting to be time consuming rebasing all these dependent patches downstream. Regards, Caio. Em qua, 14 de mar de 2018 às 21:08, Caio Lima escreveu: > > Hi all. > > Pi

Re: [webkit-dev] Ask for review in BigInt Patch

2018-03-14 Thread Caio Lima
Hi all. Pinging this review request. Em sáb, 10 de mar de 2018 às 18:29, Caio Lima escreveu: > Hi All. > > I am working into some BigInt patches and right now I'm looking for > someone to review the following Patch > (https://bugs.webkit.org/show_bug.cgi?id=182470). Saa

Re: [webkit-dev] Ask for review in BigInt Patch

2018-03-10 Thread Caio Lima
ent changes in > Test262, but I also imagined you're already doing it. I'll give it a try > anyway as I'm particularly interested in this new feature implementation. > > > > On Sat, Mar 10, 2018 at 12:29 PM, Caio Lima wrote: > >> Hi All. >> >> I

[webkit-dev] Ask for review in BigInt Patch

2018-03-10 Thread Caio Lima
Hi All. I am working into some BigInt patches and right now I'm looking for someone to review the following Patch (https://bugs.webkit.org/show_bug.cgi?id=182470). Saam reviewed it once, but since he is not available, he advised me to ask some other reviewer to take a look. Could anyone take a lo

[webkit-dev] Is Win7 build broken in tests with large Arrays?

2018-01-09 Thread Caio Lima
Hi all. I landed a BigInt Patch last week[1] and noticed that I introduced a new fail into Win7 builds (stress/big-int-constructor-gc.js.big-int-enabled for reference) and investigating the issue, I could notice that there are other stress tests failing (stress/big-match.js and stress/big-split.js

Re: [webkit-dev] Build issues due to anonymous namespace

2017-12-03 Thread Caio Lima
I agree on that. The Patch on the way as well and I will fix it. https://bugs.webkit.org/show_bug.cgi?id=180335 Em dom, 3 de dez de 2017 às 18:10, Darin Adler escreveu: > I think it’s also worthwhile to remove the anonymous namespace wrapping > each of these DestroyFunc structures when renaming

Re: [webkit-dev] Build issues due to anonymous namespace

2017-12-03 Thread Caio Lima
and I’ll > happily review it. > > -Filip > > > On Dec 3, 2017, at 8:44 AM, Caio Lima wrote: > > > > Hi guys. I'm working in a Patch that is adding some files to JSC and I > faced following issue: > > > > ./runtime/JSStringHeapCellType.cpp:36:8: err

[webkit-dev] Build issues due to anonymous namespace

2017-12-03 Thread Caio Lima
Hi guys. I'm working in a Patch that is adding some files to JSC and I faced following issue: ./runtime/JSStringHeapCellType.cpp:36:8: error: redefinition of 'DestroyFunc' ... In file included from /Users/caiolima/open_projects/WebKit/WebKitBuild/Debug/DerivedSources/JavaScriptCore/unified-sources

Re: [webkit-dev] BigInt implementation

2017-10-20 Thread Caio Lima
t; > Jordi. > > the mailing list, sorry if you recived this message more than once. > > Jordi. > > > >> >> On 19 October 2017 at 15:32, Filip Pizlo wrote: >> >>> Seems like V8’s is an ok place to start. Maybe all you’d have to do is >>> r

[webkit-dev] BigInt implementation

2017-10-18 Thread Caio Lima
Hi WebKittens. I’m planning to start implement JS BigInt proposal on JSC, however I would like to sync with you the way you are planning to implement such feature. Right now, I’m thinking in implement BigInt operations into C++ (possibly on WTF?) and make the JSBigInt use this implementation. As

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-09-05 Thread Caio Lima
k the status of build+failures. Regards, Caio. 2017-08-01 20:52 GMT-03:00 Caio Lima : > Hi all. > > FYI, I keep the last weeks investigating the issue with ARMv6 IC and I > was able to find the source of the bug and apply a quick fix to run > benchmarks again to get results. I just ran

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-08-01 Thread Caio Lima
wrote: >> >> Can you please run Octane and Kraken too? >> >> - Saam >> >> On Jul 13, 2017, at 7:47 AM, Caio Lima wrote: >> >> Finally I got the results from the last benchmark run. The results >> shows that the speed-ups are considerable compar

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-07-13 Thread Caio Lima
t; - Saam > > On Jul 13, 2017, at 7:47 AM, Caio Lima wrote: > > Finally I got the results from the last benchmark run. The results > shows that the speed-ups are considerable comparing with CLoop > version, since we get faster results in a big number of tests and > regress in

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-07-13 Thread Caio Lima
tforms that it’s just pure badness. Until you can prove > that you can change this, I think that porting should focus on making the > cloop great. Then, we can rip out support for weird CPUs rather than bringing > it back. > > -Filip > >> On Jul 5, 2017, at 6:14 PM, Caio

Re: [webkit-dev] Data Memory Barrier ARMv6 question

2017-07-05 Thread Caio Lima
ng "mcr 15 ...". The point is that we are having divergences in ARM > official reference manual about the semantics of this instruction. We > have it discussed in the bug above and I would like to know if there > is somebody with stronger ARM background that could

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-07-05 Thread Caio Lima
get these numbers related to JIT. BTW, there is a Patch that isn't JIT related (https://bugs.webkit.org/show_bug.cgi?id=172766). Regards, Caio. > -Filip > >> On Jun 13, 2017, at 6:48 PM, Caio Lima wrote: >> >> Hi All. >> >> Some of you guys might know me

[webkit-dev] Data Memory Barrier ARMv6 question

2017-07-03 Thread Caio Lima
mantics of this instruction. We have it discussed in the bug above and I would like to know if there is somebody with stronger ARM background that could help us there and then approve the patch to be committed. I thanks in advance and best regards, Caio Lima. ___

[webkit-dev] Bring back ARMv6 support to JSC

2017-06-13 Thread Caio Lima
Hi All. Some of you guys might know me through the work I have been doing in JSC. The experience working with WebKit has been great so far, thank you for the reviews! Since 1st May, we at Igalia have been working on bring back the ARMv6 support into JSC. We already have commits into our downstrea

Re: [webkit-dev] Konstantin Tokarev is now a WebKit reviewer

2017-05-22 Thread Caio Lima
Congrats annulen! 2017-05-22 21:18 GMT-03:00 Myles C. Maxfield : > Yyyy!! > > > On May 22, 2017, at 5:09 PM, Yusuke SUZUKI wrote: > > Congrats! > > On Tue, May 23, 2017 at 2:25 Mark Lam wrote: >> >> Hi everyone, >> >> I would like to announce that Konstantin Tokarev (annulen on #webkit)

Re: [webkit-dev] !!Tests for equality comparison

2017-04-27 Thread Caio Lima
O also think it's a good notation. It helps a lot the code reading IMO. Caio. Em qui, 27 de abr de 2017 às 20:33, Chris Dumez escreveu: > I also do not like this rule when it comes to integers. > > I personally think JF’s proposal to allow == 0 sounds nice. I don’t think > JF was suggesting rewr