Re: [webkit-dev] git-webkit pr now supports --no-ews / --ews flags

This is great! As it is said in "Ghost Dog: The Way of the Samurai", it is bad when one thing becomes two. Can we pick one name for this feature? Either —no-ews (git-webkit) and no-ews (GitHub) or —skip-ews (git-webkit) and skip-ews (GitHub)? Thanks, Geoff > On Jan 26, 2023, at 11:36 AM, Aakas

Re: [webkit-dev] Stop Using Raw Pointers & References in New Code

Is the idea that a checker failure should block landing a patch, or just that it should start a conversation with your patch reviewer about why this case is an exception? Maybe the ’should’ clause in the error message could clarify. In general, I do think it’s helpful to flag any new raw pointe

Re: [webkit-dev] Compile times and class-scoped enums

>> However, this change requires moving class-scoped enums out into the >> namespace scope. > > Seems worthwhile. Doesn’t seem to me like it would have far reaching effects. I agree. > +using Type = DOMAudioSessionType; Did you do this to make the patch smaller, or do you prefer this style

[webkit-dev] Ben Nham is now a WebKit Reviewer

Hi folks, I’m happy to announce that Ben Nham is now a WebKit reviewer. 🎉 Ben is an expert in many Apple technologies, and in Performance and WebPush in particular. Please feel free to reach out to Ben for reviews. Thanks, Geoff ___ webkit-dev mailing

Re: [webkit-dev] Proposal: Mandatory Commit and Merge Queue

Thanks for gathering this data! >> What are some notable cases of recent regressions that have landed because >> of non-use of commit queue and caused serious problems? > > Some recent examples of regressions that would have been prevented by > mandatory commit/merge-queue as proposed: > > htt

Re: [webkit-dev] Deployment of new EWS Non-Unified builder

> As such, I also think that the non-unified EWS being green should not be a > blocker to landing a patch. But I think having it there for information will > help the situation. At minimum, even if every engineer simply ignores the > non-unified EWS, it also makes it easier for someone trying to

Re: [webkit-dev] Proposal: Mandatory Commit and Merge Queue

>> What is the goal of this proposal? > > The goal is to increase the stability of the build Is this goal distinct from preventing regressions from landing? If so, how? > , speed up EWS by preventing regressions from landing What are some notable cases of recent regressions that have landed bec

Re: [webkit-dev] Proposal: Mandatory Commit and Merge Queue

> As we move to GitHub, I would like to propose we strengthen our protections > on `main` by making MergeQueue and CommitQueue mandatory. What is the goal of this proposal? What problem are you trying to solve, and with what level of urgency? Thanks, Geoff > On Jun 2, 2022, at 2:35 PM, Jona

Re: [webkit-dev] Proposal: Immediate Deprecation of ChangeLogs

Do I undertand correctly that the proposal here is (a) Immediately Deprecate ChangeLogs (b) Immediately end support for posting patches from Subversion checkouts? If so, do you know how many regular WebKit contributors still post patches from Subversion checkouts, and, if that

Re: [webkit-dev] ChangeLog Deprecation Plans

>> Commit message is tied to a commit, so editing commit without breaking >> commit-message is hard (how to revert one change from one commit without >> rewriting commit message? It requires some git hack). Separate independent >> COMMIT_MESSAGE file can solve this problem and makes local develo