[webkit-dev] prepare-Changelog crashing on cygwin

2010-05-10 Thread John Abd-El-Malek
: STATUS_ACCESS_VIOLATION 1796 [main] svn 14496 open_stackdumpfile: Dumping stack trace to svn.exe.stackdump exec of 'diff' failed: Bad addresssvn: 'diff' returned 255 Extracting affected function names from source files. Change author: John Abd-El-Malek j...@chromium.org. Running 'svn update' to update

Re: [webkit-dev] prepare-Changelog crashing on cygwin

2010-05-10 Thread John Abd-El-Malek
, 2010 1:35 PM, John Abd-El-Malek j...@google.com wrote: After reimaging my Windows 7 machine, prepare-Changelog always crashes for me now. It seems to have problems running svn diff. I installed cygwin through the installer on webkit.org. I don't have any anti-virus programs running

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-10-16 Thread John Abd-El-Malek
...@google.comwrote: On Thu, Oct 15, 2009 at 1:50 PM, John Abd-El-Malek j...@google.comwrote: Does this argue for making the image loading trick work all the time from JS, not just from unload handlers? I tested with IE and it looks like the image trick works all the time, not just in unload handlers. My

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-10-15 Thread John Abd-El-Malek
On Wed, Oct 14, 2009 at 7:53 PM, Maciej Stachowiak m...@apple.com wrote: On Oct 14, 2009, at 6:43 PM, John Abd-El-Malek wrote: To resurrect this thread. I'm looking in implementing some of the methods that we discussed so that web developers have no excuse in simulating sleeps in unload

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-10-15 Thread John Abd-El-Malek
On Thu, Oct 15, 2009 at 12:31 AM, Darin Fisher da...@chromium.org wrote: On Wed, Oct 14, 2009 at 7:53 PM, Maciej Stachowiak m...@apple.com wrote: On Oct 14, 2009, at 6:43 PM, John Abd-El-Malek wrote: To resurrect this thread. I'm looking in implementing some of the methods that we

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-10-14 Thread John Abd-El-Malek
-Malek j...@google.com wrote: On Thu, Sep 17, 2009 at 4:08 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 17, 2009, at 2:16 PM, John Abd-El-Malek wrote: I think the image trick is more attractive than a ping because it's easier for web developers to use. But I'm not convinced it's

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread John Abd-El-Malek
On Wed, Sep 16, 2009 at 11:03 PM, Darin Fisher da...@chromium.org wrote: On Wed, Sep 16, 2009 at 10:57 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 16, 2009, at 10:33 PM, Darin Fisher wrote: On Wed, Sep 16, 2009 at 9:59 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 16, 2009,

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread John Abd-El-Malek
On Thu, Sep 17, 2009 at 2:09 PM, Darin Fisher da...@chromium.org wrote: On Thu, Sep 17, 2009 at 12:52 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 17, 2009, at 12:14 PM, Darin Fisher wrote: On Thu, Sep 17, 2009 at 2:28 AM, Maciej Stachowiak m...@apple.com wrote: On Sep 17,

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread John Abd-El-Malek
On Thu, Sep 17, 2009 at 12:14 PM, Darin Fisher da...@chromium.org wrote: On Thu, Sep 17, 2009 at 2:28 AM, Maciej Stachowiak m...@apple.com wrote: On Sep 17, 2009, at 12:35 AM, Darin Fisher wrote: For a ping to be used as I suggested, you would need to set the href to a javascript URL

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread John Abd-El-Malek
On Thu, Sep 17, 2009 at 4:08 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 17, 2009, at 2:16 PM, John Abd-El-Malek wrote: I think the image trick is more attractive than a ping because it's easier for web developers to use. But I'm not convinced it's the cleanest method we can come

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-16 Thread John Abd-El-Malek
On Wed, Sep 16, 2009 at 1:53 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 16, 2009, at 11:23 AM, Geoffrey Garen wrote: Given some of our (Chromium-team) recent investigation into the contents of unload handlers, I'm not sure how much this move will help users, even if you don't

Re: [webkit-dev] Changes to prepare-ChangeLog

2009-07-15 Thread John Abd-El-Malek
. On Wed, Jul 15, 2009 at 12:52 AM, Gustavo Noronha Silva g...@gnome.orgwrote: On Fri, 2009-07-10 at 18:18 -0700, John Abd-El-Malek wrote: this changelist. Operations such as gcl upload CHANGENAME (upload to Rietveld) work on the group of files at the same time (also things like gcl diff/commit

Re: [webkit-dev] Changes to prepare-ChangeLog

2009-07-10 Thread John Abd-El-Malek
To add another tangent to this thread: one thing I don't like about ChangeLog files is that they make it impossible to have multiple concurrent changes in the same checkout. Yes I know that some people use git to get around this, while others use the svn-apply/svn-unapply scripts. But I feel

Re: [webkit-dev] Changes to prepare-ChangeLog

2009-07-10 Thread John Abd-El-Malek
is in this context and how bugzilla-tool would support them. Dave *From:* John Abd-El-Malek j...@google.com *To:* Ojan Vafai o...@chromium.org *Cc:* WebKit Development webkit-dev@lists.webkit.org; Mark Rowe mr...@apple.com *Sent:* Friday, July 10, 2009 5:11:53 PM *Subject:* Re: [webkit

Re: [webkit-dev] Windows Multithread issue

2009-06-16 Thread John Abd-El-Malek
Thanks for the info guys, I stand corrected. Completely forgot about the JS issue. 2009/6/15 Oliver Hunt oli...@apple.com This is not possible due to various issues with the interaction between JS across multiple webviews, and the additional assumption that all layout and painting occurs in

Re: [webkit-dev] Windows Multithread issue

2009-06-15 Thread John Abd-El-Malek
Yes it's possible. The Chromium port runs web views in different processes. You can look at the design docs and source to see how it's done, that should give you an idea of what you have to do this on different threads. 2009/6/15 熊科浪 xiongkel...@hotmail.com hi I want to develop c++

Re: [webkit-dev] to reitveld or not to reitveld

2009-06-10 Thread John Abd-El-Malek
On Wed, Jun 10, 2009 at 8:12 AM, Joe Mason joe.ma...@torchmobile.comwrote: Mark Rowe wrote: - UI is intimidating to newcomers. This is clearly subjective, but since the goal here is to make the review process friendlier, especially for new contributors, I think it deserves calling out.

Re: [webkit-dev] to reitveld or not to reitveld

2009-06-08 Thread John Abd-El-Malek
On Mon, Jun 8, 2009 at 5:15 PM, Eric Seidel macd...@gmail.com wrote: At least one person has tried to tie review-board with bugzilla: http://www.visophyte.org/blog/2009/03/20/using-review-board-for-bugzilla-request-queues-reviews/ I expect that we'd have to hack review board to do

Re: [webkit-dev] SharedWorkers alternate design

2009-05-27 Thread John Abd-El-Malek
On Wed, May 27, 2009 at 12:00 AM, Jeremy Orlow jor...@chromium.org wrote: On Tue, May 26, 2009 at 9:40 PM, Maciej Stachowiak m...@apple.com wrote: On May 26, 2009, at 6:11 PM, Jeremy Orlow wrote: Did you say partly because it's more complicated than just splitting one class (and only

Re: [webkit-dev] SharedWorkers alternate design

2009-05-26 Thread John Abd-El-Malek
I agree that this approach is powerful. However there are (not too frequent) situations when a port like Chromium wants to use both the WebKit implementation and its own implementation, switching in runtime. For workers, this happened with WorkerContextProxy/WorkerObjectProxy which are the

Re: [webkit-dev] SharedWorkers alternate design

2009-05-26 Thread John Abd-El-Malek
On Tue, May 26, 2009 at 5:00 PM, Sam Weinig sam.wei...@gmail.com wrote: On Tue, May 26, 2009 at 11:08 AM, John Abd-El-Malek j...@google.comwrote: I agree that this approach is powerful. However there are (not too frequent) situations when a port like Chromium wants to use both the WebKit

Re: [webkit-dev] SharedWorkers alternate design

2009-05-26 Thread John Abd-El-Malek
On Tue, May 26, 2009 at 5:31 PM, Jeremy Orlow jor...@chromium.org wrote: On Tue, May 26, 2009 at 5:21 PM, Jeremy Orlow jor...@chromium.org wrote: On Tue, May 26, 2009 at 5:05 PM, Sam Weinig sam.wei...@gmail.com wrote: On Tue, May 26, 2009 at 4:12 PM, Jeremy Orlow jor...@chromium.orgwrote:

Re: [webkit-dev] SharedWorkers alternate design

2009-05-25 Thread John Abd-El-Malek
On Fri, May 22, 2009 at 2:50 PM, Jeremy Orlow jor...@chromium.org wrote: On Fri, May 22, 2009 at 2:25 PM, Drew Wilson atwil...@google.com wrote: Following up on this, I had a question about the best way to enable the implementation of SharedWorkerRepository to vary for different platforms.