Re: [webkit-dev] Turning CSS Variables Off

2013-05-16 Thread Mike Lawther
On 16 May 2013 17:50, Sergio Villar Senin svil...@igalia.com wrote: Yeah I know. That's why I tried to get in contact with Luke Macpherson, the author of the current implementation, but it looks like he isn't working in Chromium any more. Alan Cutter is the maintainer of CSS Variables in

Re: [webkit-dev] Common build system (was Re: WebKit Wishes)

2013-02-03 Thread Mike Lawther
Hi Maciej! On 31 January 2013 11:15, Maciej Stachowiak m...@apple.com wrote: It's far simplest for us if: (a) There is an Xcode project (or a Makefile) that builds the Mac port checked in to source control. (b) The generated project invokes only tools that are part of the default Mac OS X

Re: [webkit-dev] Int/FloatPoint and Int/FloatSize

2013-01-03 Thread Mike Lawther
On 4 January 2013 16:15, Simon Fraser simon.fra...@apple.com wrote: Introducing the concept of a vector could then be done in a second phase. What would you call this type, avoiding confusion with Vector? Rename that to DynamicallyResizableRandomlyAccessibleT, because, you know, Euclid got

[webkit-dev] r- your own patches [was: Re: RenderArena: Teaching an old dog new tricks]

2012-11-15 Thread Mike Lawther
On 16 November 2012 09:59, Ryosuke Niwa rn...@webkit.org wrote: While I don’t want to further agitate the issue or go off on a tangent, and agree that we must address the security aspect before getting rid of RenderArena, only WebKit reviewers can r- patches written by other contributors.

Re: [webkit-dev] Time to remove LIKELY and UNLIKELY macros?

2012-10-02 Thread Mike Lawther
On 2 October 2012 16:29, Maciej Stachowiak m...@apple.com wrote: Note, despite the stackoverflow thread cited, I would be highly surprised if static branch predicition had no effect ever, even on modern architectures. While recent intel CPUs have very good dynamic branch prediction, the

Re: [webkit-dev] Is there a rule to use UNUSED_PARAM ?

2012-10-01 Thread Mike Lawther
On 2 October 2012 04:30, Oliver Hunt oli...@apple.com wrote: That's what the ASSERT_UNUSED(variable, assertion) macro is for :D fwiw, my first reading of that name had me thinking it meant 'ASSERT that this variable is unused' in the vein of macros I've seen in other places like ASSERT_TRUE,

Re: [webkit-dev] Is there a rule to use UNUSED_PARAM ?

2012-10-01 Thread Mike Lawther
ASSERT_WITH_OTHERWISE_UNUSED. On 2 October 2012 10:51, Ryosuke Niwa rn...@webkit.org wrote: How about ASSERT_OR_UNUSED or ASSERT_USING_UNUSED? On Mon, Oct 1, 2012 at 5:23 PM, Darin Adler da...@apple.com wrote: On Oct 1, 2012, at 5:21 PM, Mike Lawther mikelawt...@google.com wrote: my

Re: [webkit-dev] String::operator+= considered harmful

2012-09-04 Thread Mike Lawther
On 5 September 2012 09:44, Dirk Schulze dschu...@adobe.com wrote: It is very likely that even future code will land with this operator instead of StringBuilder. Not if Adam removes the operator as he proposed earlier :) If operator+= cannot be made sufficiently efficient, we could always

Re: [webkit-dev] String::operator+= considered harmful

2012-09-04 Thread Mike Lawther
If operator+= cannot be made sufficiently efficient, we could always leave the operator there, but have it ASSERT with a message saying to use StringBuilder. Please not this. Failing at compile time is much better than failing at runtime in debug builds only. I was only half serious,

[webkit-dev] editbugs permission

2012-06-13 Thread Mike Lawther
Hi there, I'd like to ask for EditBugs permission for dstockw...@chromium.org, who has already landed a couple of patches and is helping us triage bugs. thanks! mike ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Can we distinguish imported tests in LayoutTests/css3 ?

2012-06-11 Thread Mike Lawther
I'm the guy that added css3/calc tests. I did so because I not all my tests are 'text only' tests, but I still wanted them all together. My understanding was that the 'fast' directory was intended for 'text only' tests only. Does having the 'fast' directory still serve a useful purpose? I reckon

Re: [webkit-dev] trac.webkit.org is down

2012-03-19 Thread Mike Lawther
On 19 March 2012 22:44, Alexis Menard alexis.men...@openbossa.org wrote: Hi, On Wed, Feb 29, 2012 at 12:00 PM, William Siegrist wsiegr...@apple.com wrote: This should be fixed now. trac is down today for us. bugs.webkit.org is also down with this error : I'm also seeing them down with

[webkit-dev] optimising png files in LayoutTests - an experiment

2012-01-24 Thread Mike Lawther
Hi guys, Just thought I'd share the results of an experiment I did in optimising the png files in LayoutTests. I used a tool on Mac called ImageOptim (http://imageoptim.pornel.net/) which tries a set of different png lossless optimising tools (like pngcrush - I also downloaded and included

Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing

2012-01-08 Thread Mike Lawther
And for git users: http://trac.webkit.org/wiki/UsingGitWithWebKit (there is a section on setting mime-types via subversion's config file). On 9 January 2012 13:44, Benjamin Poulain benja...@webkit.org wrote: On Sun, Jan 8, 2012 at 6:15 PM, Dan Bernstein m...@apple.com wrote: Please set the

Re: [webkit-dev] Fwd: Re: Painting Phases

2011-05-10 Thread Mike Lawther
       There is a good video somewhere that Eric Seidel describes the rendering inside WebKit that covers this. I think http://www.youtube.com/watch?v=RVnARGhhs9w is the right one. mike ___ webkit-dev mailing list webkit-dev@lists.webkit.org