Re: [webkit-dev] Unsigned to avoid negative values

2023-01-26 Thread Myles Maxfield via webkit-dev
d when doing math on buffer offsets and sizes, and >> can result in OOB bugs. I believe Apple’s media frameworks code has a “no >> unsigned usage” rule because of that. I’m surprised that no-one has raised >> it in this discussion. >> >> Simon >> >>> On

Re: [webkit-dev] Unsigned to avoid negative values

2023-01-26 Thread Myles Maxfield via webkit-dev
https://github.com/WebKit/WebKit/pull/9199 > On Jan 26, 2023, at 12:31 AM, Myles Maxfield via webkit-dev > wrote: > > Okay, sounds like we’re all pretty much in agreement. > > How about I add a rule to our style guide that says “use unsigned types to > represen

Re: [webkit-dev] Unsigned to avoid negative values

2023-01-26 Thread Myles Maxfield via webkit-dev
M, Ryosuke Niwa via webkit-dev >>> wrote: >>> >>> >>>> On Jan 24, 2023, at 2:00 AM, Myles Maxfield via webkit-dev >>>> wrote: >>> >>> I recently learned that the C++ core guidelines recommend against using >>> unsigned

[webkit-dev] Unsigned to avoid negative values

2023-01-24 Thread Myles Maxfield via webkit-dev
Hello! I recently learned that the C++ core guidelines recommend against using unsigned to avoid negative values. Section 4.4 on page 73 of The C++ Programming Language says unsigned types should be used for bitfields and not in an attempt to ensure values are positive. Some talks by people on

Re: [webkit-dev] WebKit Style: Whitespace for Objective-C protocols

2022-03-02 Thread Myles Maxfield via webkit-dev
I’ve posted a patch to make these changes official: https://bugs.webkit.org/show_bug.cgi?id=237406 > On Feb 24, 2022, at 9:09 AM, Darin Adler wrote: > > I personally prefer id, and would be happy to standardize on > that. I don’t really care that much about statistics about usage in our >

[webkit-dev] WebKit Style: Whitespace for Objective-C protocols

2022-02-21 Thread Myles Maxfield via webkit-dev
Hello! I was working on a patch recently where I wanted to give an Objective-C variable a type of “id that conforms to protocol Foo.” Should this be spelled like this: id myVariable Or like this: id myVariable I don’t see anything about this in the WebKit style guide

Re: [webkit-dev] Chris Lord is now a WebKit reviewer!

2021-12-10 Thread Myles Maxfield via webkit-dev
 > On Dec 10, 2021, at 2:05 AM, Alejandro G. Castro via webkit-dev > wrote: > > > Hello! > > I'm delighted to announce that Chris Lord is now a WebKit reviewer. He > added OffscreenCanvas support, helped with the scrolling architecture > and has contributed a lot of code to WPE and GTK

[webkit-dev] Cameron McCormack is now a WebKit reviewer!

2021-11-08 Thread Myles Maxfield via webkit-dev
Hello! I am delighted to announce that Cameron McCormack is now a WebKit reviewer. Congratulations, Cameron!___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Fuzzy Reftest Plans, and Metadata Locations

2021-10-29 Thread Myles Maxfield via webkit-dev
> On Oct 28, 2021, at 10:24 AM, Sam Sneddon via webkit-dev > wrote: > > Hi! > > As part of the ongoing work on GPU Process, we’re interested in adding > support for reftest fuzzy matching (i.e., allowing a certain amount of > tolerance when comparing the generated images). > > Our

Re: [webkit-dev] -Wreturn-type and -Wredundant-move reminders

2021-10-29 Thread Myles Maxfield via webkit-dev
> On Oct 19, 2021, at 1:15 PM, Michael Catanzaro via webkit-dev > wrote: > > Hi devs, > > A reminder about this common idiom: > > switch (...) { > case Foo: > return ...; > case Bar: > return ...; > } > RELEASE_ASSERT_NOT_REACHED(); > > When it's intended that the code always returns

Re: [webkit-dev] Request for position: supports() extended syntax for @font-face

2021-08-09 Thread Myles Maxfield via webkit-dev
> On Aug 9, 2021, at 7:49 AM, Dominik Röttsches wrote: > >  > Hi @ webkit-dev, hi Myles, > > we'd like to know your opinion on the extended supports() > syntax of the @font-face src: descriptor. > > Specification or proposal URL: >

Re: [webkit-dev] Request for position: CSS @font-face descriptor advance-override

2021-08-09 Thread Myles Maxfield via webkit-dev
Positive signal on size-adjust > On May 4, 2021, at 3:38 AM, Dominik Röttsches via webkit-dev > wrote: > >  > As an update to our intent here. as posted by Xiaocheng earlier, we're > planning to ship the size-adjust descriptor. > >> On Mon Feb 22 16:50:28 PST 2021 Xiaocheng Hu