Re: [webkit-dev] Using memcmp

2009-07-01 Thread Patrick Hanna
On Jun 30, 2009, at 2:53 PM, Maciej Stachowiak wrote: On Jun 30, 2009, at 9:57 AM, Patrick Hanna wrote: I have noticed that rather than using memcmp for comparing strings, webkit likes to cast to uint32_t* and compare in a for loop. For example, WebCore::equal in AtomicString.cpp

Re: [webkit-dev] Using memcmp

2009-07-01 Thread Patrick Hanna
. StringHash::equal() needs a patch (as done for WebCore::equal)...at least for SH4 platform. If you prefer I can submit such a patch for SH4 platform. Tnx. Best regards, S. On Wed July 1 2009, Patrick Hanna wrote: On Jun 30, 2009, at 2:53 PM, Maciej Stachowiak wrote: On Jun 30, 2009, at 9

[webkit-dev] Using memcmp

2009-06-30 Thread Patrick Hanna
I have noticed that rather than using memcmp for comparing strings, webkit likes to cast to uint32_t* and compare in a for loop. For example, WebCore::equal in AtomicString.cpp and StringHash::equal in StringHash.h. Is there any reason not to memcmp? I am assuming that most implementations

Re: [webkit-dev] How to flatten frames?

2009-06-30 Thread Patrick Hanna
The patch on Android is against a different webkit revision so who knows what will happen when patching against the latest webkit. My first thought is to try view-resize(width(), height()) instead of using m_width and m_height but I don't know what that will change. Have you looked at the

[webkit-dev] RenderObject ASSERT

2009-02-25 Thread Patrick Hanna
I suspect that I am hitting this assert due to local changes but I can't seem to figure out how to fix it. The assert I am hitting is in RenderObject's destructor: ASSERT(!node() || documentBeingDestroyed() || !document()-frame()- view() || document()-frame()-view()-layoutRoot() != this);

Re: [webkit-dev] network calls...curl implementation

2009-01-29 Thread Patrick Hanna
curl/ResourceHandleManager.cpp handles all the requests issued to curl. The actual http implementation exists in libcurl which is not part of the webkit source tree. Patrick On Jan 29, 2009, at 12:09 PM, abhas saroha wrote: hi all, wanted to know how to use the curl implementation in

Re: [webkit-dev] How to use webkit ?

2008-07-10 Thread Patrick Hanna
I don't think Android is the answer either. Most of the webkit port is very dependent on the Android OS and is not portable to other java frameworks. I think Brent is right when he said your question is very broad. If you are looking to write a java app that runs on multiple systems,

Re: [webkit-dev] FrameLoaderClient notifications

2008-03-13 Thread Patrick Hanna
Artem, For our port, we construct the FrameLoaderClient with a pointer to the Frame object. So in all the progress notification callbacks we can say m_frame-loader()-url() or whatever to get the current url of the frame. Patrick On Mar 13, 2008, at 7:11 AM, Artem Ananiev wrote: Hi, I

Re: [webkit-dev] FrameLoaderClient notifications

2008-03-13 Thread Patrick Hanna
, in postProgressStartedNotification as it contains the current URL, not the URL which is about to be loaded... Thanks, Artem Patrick Hanna wrote: Artem, For our port, we construct the FrameLoaderClient with a pointer to the Frame object. So in all the progress notification callbacks we can say

[webkit-dev] The mysterious IconDatabase

2007-09-18 Thread Patrick Hanna
I am having trouble using the IconDatabase successfully. I was wondering if I am either using it incorrectly or if Safari is doing some extra work to get the correct favicon for a given site. Here is the scenario. I am going to assume that each icon is retained at least once so that icons

Re: [webkit-dev] The mysterious IconDatabase

2007-09-18 Thread Patrick Hanna
on the icon database for this knowledge. Safari does have a little logic to pevent the icon in the URL field from flashing back and forth between a generic and non-generic icon as you type in a URL. John On Sep 18, 2007, at 9:53 AM, Patrick Hanna wrote: So I do *not* have the 25557 patch

Re: [webkit-dev] The mysterious IconDatabase

2007-09-18 Thread Patrick Hanna
just need to add that sort of logic for hosts that match. Thanks for the help, Pat On Sep 18, 2007, at 1:32 PM, John Sullivan wrote: On Sep 18, 2007, at 10:25 AM, Patrick Hanna wrote: I have discovered that I have an IconDatabase that is older than the new multi-thread database