[webkit-dev] RenderLayer::isStackingContext() confusion

2013-04-03 Thread Shawn Singh
Background: According to CSS 2.1 spec, an element becomes a stacking context when: - it is positioned (relative, absolute, or fixed) - and it has a non-auto z-index Spec also mentions that there's room for expanding this definition; the examples I know about are fixed-position elements and

Re: [webkit-dev] RenderLayer::isStackingContext() confusion

2013-04-03 Thread Shawn Singh
isStackingContext but that might be slower. Changing the name of the method would make the code more confusing, since it is checking the right thing just through some complicated process. On Wed, Apr 3, 2013 at 3:48 PM, Shawn Singh shawnsi...@chromium.orgwrote: Background: According to CSS 2.1

Re: [webkit-dev] css: rotateY(90) with perspective()

2013-02-12 Thread Shawn Singh
Hi Marcin, I wonder if you might accidentally have a perspective-origin set differently? Or maybe there is something in your code where window size that affects how the transforms appear? Maybe you can attach a reduced simple example of the difference you're seeing? I just whipped up the

Re: [webkit-dev] Int/FloatPoint and Int/FloatSize

2013-01-03 Thread Shawn Singh
Personally I like the idea of removing the subtraction operator (point minus point returns size) and make it explicit. *** However ***, if we change the data type of objects from Size to Point, we have to be careful to check whether they are ever mapped by transforms. In particular, Points use

Re: [webkit-dev] bugs.webkit.org and trac.webkit org down?

2012-08-07 Thread Shawn Singh
It also seems to be down for me here in Mountain View, CA USA, right next to Apple... On Tue, Aug 7, 2012 at 9:20 AM, Osztrogonac Csaba o...@inf.u-szeged.huwrote: Hi, It seems bugs.webkit.org and trac.webkit.org is unavailable now. (at least from Hungary) Have you got any idea what

Re: [webkit-dev] TransformationMatrix rotation code and floating-point precision

2012-05-15 Thread Shawn Singh
on bugs.webkit.org if I were you, and cc relevant people (use trac.webkit.org to see who has authored/reviewed patches in the relevant files). - Ryosuke On Mon, May 14, 2012 at 7:30 PM, Shawn Singh shawnsi...@chromium.orgwrote: I'm looking at TransformationMatrix::rotate3d(rx, ry, rz

Re: [webkit-dev] TransformationMatrix rotation code and floating-point precision

2012-05-15 Thread Shawn Singh
Nope, the matrices in the code are just basic rotations about x/y/z/ axes. On Tue, May 15, 2012 at 9:25 AM, Shawn Singh shawnsi...@google.com wrote: Nope, the matrices in the code are just basic rotations about x/y/z/ axes. ~Shawn On Tue, May 15, 2012 at 7:57 AM, W. James MacLean wjmacl

[webkit-dev] TransformationMatrix rotation code and floating-point precision

2012-05-14 Thread Shawn Singh
Hi all, I'm looking at TransformationMatrix::rotate3d(rx, ry, rz). This code does something indirect, and I don't understand why. Instead of initializing each rotation using sin(theta), cos(theta), the code computes theta/2, and then uses trig identities to initialize the rotation matrix. I

[webkit-dev] spinoff from webkit-patch -g discussion

2012-02-29 Thread Shawn Singh
Quote from the discussion: that's why I said that having something like webkit-patch upload range_of_commits will be nice to have, as you wouldn't have to create a new branch and rebase several commits, just to upload a new patch to the bz. You can do this with the current -g option by

Re: [webkit-dev] spinoff from webkit-patch -g discussion

2012-02-29 Thread Shawn Singh
Awesome thanks very much. =) Yeah, the way you proposed to deal with it seems better, now I think of it. ~Shawn On Wed, Feb 29, 2012 at 4:33 PM, Shawn Singh shawnsi...@google.com wrote: Awesome thanks very much. =) Yeah, the way you proposed to deal with it seems better, now I think