Re: [webkit-dev] Comments in the code (Was Please include function-level comments in change log entries)

2012-07-11 Thread Yaar Schnitman
[(dev time of maintaining comments) + (risk of outdated comments causing bugs X dev time of fixing resulting bugs)] (dev time gained by more contributors each being more knowledgable) No? On Wed, Jul 11, 2012 at 8:53 AM, Ryosuke Niwa rn...@webkit.org wrote: On Jul 11, 2012 8:43 AM, John

Re: [webkit-dev] Misplaced files

2010-08-31 Thread Yaar Schnitman
Regarding renaming files: The .cpp and .h file names need to correspond with .idl names, which in turn correspond with the interfaces specified in these .idl. The later are standard, user-facing strings. This means that you can't change them without fixing a lot of generation and build rules. If

Re: [webkit-dev] Testing changes to CodeGenerator*.pm

2010-04-29 Thread Yaar Schnitman
I see run-bindings-tests is primary a productivity tool: Faster development, easy debugging, better reviews. But it only works if the golden copies don't fall into disrepair = Hence the need to bake this tool into the general testing framework (run-webkit-tests, pre-submit checks, etc.). It will

[webkit-dev] Introducing the Chromium Build Bots

2009-12-17 Thread Yaar Schnitman
Hi, We have recently set up 3 new builds bots at build.webkit.org: Chromium-Win-Release, Chromium-Mac-Release Chromium-Linux-Release. These bots build the Chromium Webkit Port http://trac.webkit.org/wiki/Chromium. They don't run layout tests yet, but will in the future. These bots should be used

Re: [webkit-dev] Proposing style guide change regarding braces on conditional arms

2009-12-03 Thread Yaar Schnitman
On Thu, Dec 3, 2009 at 11:36 AM, Jeremy Orlow jor...@chromium.org wrote: On Thu, Dec 3, 2009 at 11:20 AM, Alexey Proskuryakov a...@webkit.orgwrote: On 02.12.2009, at 23:35, Maciej Stachowiak wrote: One possible conservative modification to the rule is that if you have a multi-block if ...

Re: [webkit-dev] trac.webkit.org links via Google.com

2009-12-01 Thread Yaar Schnitman
Robots.txt can exclude most of the trac site, and then include the sitemap.xml. This way you block most of the junk and only give permission to the important file. All major search engine support sitemap.xml, and those that don't will be blocked by robots.txt. A script could generate sitemap.xml

Re: [webkit-dev] trac.webkit.org links via Google.com

2009-12-01 Thread Yaar Schnitman
://trac.webkit.org/changeset/1http://trac.webkit.org/changeset/#%7Brevision%7D to http://trac.webkit.org/changeset/6 (It's going to be a big file alright). On Tue, Dec 1, 2009 at 11:33 AM, Mark Rowe mr...@apple.com wrote: On 2009-12-01, at 11:04, Yaar Schnitman wrote: Robots.txt can exclude most

Re: [webkit-dev] trac.webkit.org links via Google.com

2009-11-30 Thread Yaar Schnitman
A sitemap.xml file is a more modern way of telling Google how to crawl a site and the traffic can be throttled in Google's webmaster tools ( http://www.google.com/webmasters/tools/). Creating a daily script that generates sitemap.xml for webkit's SVN repo should trivial. There are probably trac

Re: [webkit-dev] The Chromium WebKit API

2009-11-12 Thread Yaar Schnitman
Hi, WebKit/chromium is now a live directory. We have completed committing the bulk of the Chromium WebKit API into WebKit/chromium and this code is now integrated to Chromium. Our next steps, as described below, are to commit a 2nd wave (much smaller) of API additions, and to port DumpRenderTree

Re: [webkit-dev] git.webkit.org/WebKit.git out of sync from svn repository?

2009-11-10 Thread Yaar Schnitman
Hi all, I think we have this problem again. Webkit svn is on r50761, but I can only git pull up to r50738. -Yaar On Sun, Nov 8, 2009 at 5:11 PM, Fumitoshi Ukai (鵜飼文敏) u...@chromium.orgwrote: On Sat, Nov 7, 2009 at 6:10 AM, William Siegrist wsiegr...@apple.comwrote: On Nov 5, 2009, at 8:32

Re: [webkit-dev] Performance of NamedAttrMap

2009-10-29 Thread Yaar Schnitman
I encountered a similar (potential) performance problem with style properties (see CSSMutableStyleDeclaration::findPropertyWithId), which are stored in an unordered vector too. A potential solution would be to create a HashMap only for elements / style properties with more than K (5+?)