In general it's pretty safe to cq+ a patch, especially an old one.
Since the cq + EWS tests patches better than just about any committer
ever does manually. :)
We built infrastructure to have the sherriff-bot auto-rollout patches
which caused any tree redness. If folks want, we could turn that on
If you want to be extra sure that someone won't commit-queue your
patch, you can mark it commit-queue-. Generally, though, we don't
mark patches from committers commit-queue+ unless the committer has
marked the patch commit-queue?.
Adam
On Mon, Jun 20, 2011 at 11:35 AM, Dirk Pranke wrote:
> I
I had one of the bugs in this state, and I had not landed it because I
had been meaning to do some more testing to see if it caused
regressions. However, someone CQ+'ed it over the weekend, and it was
committed w/o my involvement. Fortunately, it did not appear to cause
massive regressions (thankfu
On a similar note of bug cleanup, I have also seen lot of issues which are
still in Unconfirmed state, even though the bug analysis says either the
issue is not reproducible etc etc.
So, Is there a way to clean up such bugs so that they don't unnecessarily
come up in queries. What is the tradition
webkit-patch upload clears all flags when obsoleting a patch. We
could make it not clear r- if you like. I know of no way to construct
a query like http://webkit.org/pending-commit in our current bugzilla
without clearing r+ on obsolete patches/closed bugs. We clear flags
(specifically r+) to ma
IIRC, Mozilla's bugzilla can "hide" obsolete patches (?). If so, why can not
webkit's bugzilla?
I actually do not like the way the review flags are cleared today only in
order to make the tools and pending-xxx pages happier. IMO the review flags
give much about the history of the bug. In that matt
On Fri, Jun 17, 2011 at 11:13 PM, Peter Kasting wrote:
> On Fri, Jun 17, 2011 at 10:56 PM, Adam Barth wrote:
>> 2) Mark the patch as obsolete / clear the review flag if we're not
>> going to land the patch.
>
> Does the slash mean "do both"? I
> have https://bugs.webkit.org/show_bug.cgi?id=47036
On Fri, Jun 17, 2011 at 10:56 PM, Adam Barth wrote:
> 2) Mark the patch as obsolete / clear the review flag if we're not
> going to land the patch.
Does the slash mean "do both"? I have
https://bugs.webkit.org/show_bug.cgi?id=47036 on that list and the only r+ed
patch on it is already marked o
There are a 194 open bugs with an R+ patches attached to them:
https://bugs.webkit.org/buglist.cgi?query_format=advanced&short_desc_type=notregexp&short_desc=%5C%5BS60%5C%5D&long_desc_type=substring&long_desc=&bug_file_loc_type=allwordssubstr&bug_file_loc=&keywords_type=allwords&keywords=&bug_stat
9 matches
Mail list logo