Hi, developers,
I'd really like my patches to be reviewed and landed. Could any
reviewer/commiter help me? The normal review/commit queue mechanisms aren't
suitable for the the patches because the layout-tests in them are almost
always out-dated.
Thanks,
Xianzhu
2010/8/1 Xianzhu Wang
In fact the (really lousy) model I've employed in the past when this situation
has arisen is that I hack the render tree dump to continue to dump the old
rendering. The render tree dumping code is full of hacks as a result and is
basically lying about many things at this point.
It would be
For this particular bug (the br one), even ref tests would be inadequate,
since the reference renderings would have to change too.
dave
On Jun 4, 2010, at 2:17 PM, Dirk Pranke wrote:
One admittedly painful way to do this would be to dump two render
trees, an old format and a new format, and
When there are only a couple tests that need new expectations, you can get
away with committing your patch with the expectations for the platforms you
have access to and then immediately grabbing the new expectations off the
buildbots.
There is currently no good way to address the cases where
Thanks Dan for reply.
2010/6/2 Dan Bernstein m...@apple.com
Hi Xianzhu,
On Jun 1, 2010, at 9:37 PM, Xianzhu Wang wrote:
Hi,
I'm new to webkit development, and I'd like to hear opinions about the
problems I met.
Now I'm trying to fix some old layout bugs, for example:
* white space
Hi,
I'm still wondering what the best practice is to deal with many updated
layout tests in a patch. It seems I must run the layout tests on all
effected platforms by myself to ensure a green build after committing the
patch, right? This is really difficult to me. Is there a easier way?
Thanks,
Hi,
I'm new to webkit development, and I'd like to hear opinions about the
problems I met.
Now I'm trying to fix some old layout bugs, for example:
* white space preceding br (
https://bugs.webkit.org/show_bug.cgi?id=37261)
* relative font-size (https://bugs.webkit.org/show_bug.cgi?id=18413)
Hi Xianzhu,
On Jun 1, 2010, at 9:37 PM, Xianzhu Wang wrote:
Hi,
I'm new to webkit development, and I'd like to hear opinions about the
problems I met.
Now I'm trying to fix some old layout bugs, for example:
* white space preceding br (https://bugs.webkit.org/show_bug.cgi?id=37261)
8 matches
Mail list logo