On Wed, Mar 13, 2013 at 3:36 PM, Eric Seidel e...@webkit.org wrote:
Given the history of that page, I'm not sure it truly reflects the
consensus of the project:
https://trac.webkit.org/wiki/CreatingLayoutTests?action=history
Regardless of whether you are making a platform independent change
The steps described here differ from what I've been doing. In the interest
of closure and port happiness, I've updated the wiki to reflect what is
being proposed:
https://trac.webkit.org/wiki/CreatingLayoutTests
Please feel free to update it further.
Philip
On Tue, Feb 26, 2013 at 2:34 PM,
Thanks for following up Philip. I don't feel like this thread met
much consensus, more just went off into the weeds.
Given the history of that page, I'm not sure it truly reflects the
consensus of the project:
https://trac.webkit.org/wiki/CreatingLayoutTests?action=history
Regardless of
On Tue, Feb 26, 2013 at 1:55 AM, Tom Hudson tomhud...@google.com wrote:
On Mon, Feb 25, 2013 at 10:34 PM, Ryosuke Niwa rn...@webkit.org wrote:
It should be fairly straight forward to create a tool that analyzes files
changed in each commit and deduce which tests' expected results have been
On Tue, Feb 26, 2013 at 12:47 PM, Dirk Pranke dpra...@chromium.org wrote:
On Tue, Feb 26, 2013 at 2:11 AM, Ryosuke Niwa rn...@webkit.org wrote:
On Tue, Feb 26, 2013 at 1:55 AM, Tom Hudson tomhud...@google.com
wrote:
On Mon, Feb 25, 2013 at 10:34 PM, Ryosuke Niwa rn...@webkit.org
wrote:
Hi,
Ryosuke Niwa írta:
(snip)
I don't like the idea that now I have to either use this tool or
manually read through TestExpectations to find tests that need
rebaseline. It's also annoying if we had all contributors add new lines
to TestExpectations because those changes will almost always
On Tue, Feb 26, 2013 at 1:03 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Tue, Feb 26, 2013 at 12:47 PM, Dirk Pranke dpra...@chromium.org wrote:
On Tue, Feb 26, 2013 at 2:11 AM, Ryosuke Niwa rn...@webkit.org wrote:
On Tue, Feb 26, 2013 at 1:55 AM, Tom Hudson tomhud...@google.com
wrote:
I've noticed as of late several different approaches being used when
adding/changing LayoutTests which need rebaselining on other platforms.
Obviously we cannot expect developers to test/rebaseline on all platforms
before landing given our current infrastructure.
But what should we expect them
On Mon, Feb 25, 2013 at 12:38 PM, Eric Seidel esei...@google.com wrote:
I've noticed as of late several different approaches being used when
adding/changing LayoutTests which need rebaselining on other platforms.
Obviously we cannot expect developers to test/rebaseline on all platforms
before
On Mon, Feb 25, 2013 at 12:52 PM, Dirk Pranke dpra...@google.com wrote:
On Mon, Feb 25, 2013 at 12:38 PM, Eric Seidel esei...@google.com wrote:
I've noticed as of late several different approaches being used when
adding/changing LayoutTests which need rebaselining on other platforms.
On Mon, Feb 25, 2013 at 1:22 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Mon, Feb 25, 2013 at 12:52 PM, Dirk Pranke dpra...@google.com wrote:
On Mon, Feb 25, 2013 at 12:38 PM, Eric Seidel esei...@google.com wrote:
I've noticed as of late several different approaches being used when
On Mon, Feb 25, 2013 at 1:29 PM, Dirk Pranke dpra...@google.com wrote:
On Mon, Feb 25, 2013 at 1:22 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Mon, Feb 25, 2013 at 12:52 PM, Dirk Pranke dpra...@google.com
wrote:
I remember some discussion of a [rebaseline] keyword in
On Mon, Feb 25, 2013 at 1:33 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Mon, Feb 25, 2013 at 1:29 PM, Dirk Pranke dpra...@google.com wrote:
On Mon, Feb 25, 2013 at 1:22 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Mon, Feb 25, 2013 at 12:52 PM, Dirk Pranke dpra...@google.com
wrote:
I
On Mon, Feb 25, 2013 at 1:39 PM, Dirk Pranke dpra...@google.com wrote:
On Mon, Feb 25, 2013 at 1:33 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Mon, Feb 25, 2013 at 1:29 PM, Dirk Pranke dpra...@google.com wrote:
On Mon, Feb 25, 2013 at 1:22 PM, Ryosuke Niwa rn...@webkit.org wrote:
On
On Mon, Feb 25, 2013 at 2:21 PM, Silvia Pfeiffer silvi...@chromium.orgwrote:
On Tue, Feb 26, 2013 at 8:22 AM, Ryosuke Niwa rn...@webkit.org wrote:
I object to adding such a thing. People add and forget about these
entries way too often:
# Needs rebaseline
On Mon, Feb 25, 2013 at 2:36 PM, Rouslan Solomakhin rous...@chromium.orgwrote:
On Mon, Feb 25, 2013 at 2:05 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Mon, Feb 25, 2013 at 1:39 PM, Dirk Pranke dpra...@google.com wrote:
Are you suggesting we should land a failling baseline in the meantime?
On Mon, Feb 25, 2013 at 2:48 PM, Dirk Pranke dpra...@google.com wrote:
On Mon, Feb 25, 2013 at 2:05 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Mon, Feb 25, 2013 at 1:39 PM, Dirk Pranke dpra...@google.com wrote:
Are you suggesting we should land a failling baseline in the meantime?
No.
On Mon, Feb 25, 2013 at 3:53 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Mon, Feb 25, 2013 at 2:48 PM, Dirk Pranke dpra...@google.com wrote:
On Mon, Feb 25, 2013 at 2:05 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Mon, Feb 25, 2013 at 1:39 PM, Dirk Pranke dpra...@google.com
wrote:
Are you
On Mon, Feb 25, 2013 at 3:36 PM, Glenn Adams gl...@skynav.com wrote:
On Mon, Feb 25, 2013 at 3:53 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Mon, Feb 25, 2013 at 2:48 PM, Dirk Pranke dpra...@google.com wrote:
On Mon, Feb 25, 2013 at 2:05 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Mon,
On Mon, Feb 25, 2013 at 5:27 PM, Ryosuke Niwa rn...@webkit.org wrote:
Quite frankly, I don't want it to be my (or anyone but patch author's) job
to take care of all these stale entries people add.
I agree, but I think that sloppy follow-up doesn't mean the approach is
necessarily bad. We have
On Feb 25, 2013, at 4:27 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Mon, Feb 25, 2013 at 3:36 PM, Glenn Adams gl...@skynav.com wrote:
On Mon, Feb 25, 2013 at 3:53 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Mon, Feb 25, 2013 at 2:48 PM, Dirk Pranke dpra...@google.com wrote:
On Mon, Feb
On Mon, Feb 25, 2013 at 6:17 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Mon, Feb 25, 2013 at 5:06 PM, Glenn Adams gl...@skynav.com wrote:
On Mon, Feb 25, 2013 at 5:27 PM, Ryosuke Niwa rn...@webkit.org wrote:
Quite frankly, I don't want it to be my (or anyone but patch author's)
job to
On Mon, Feb 25, 2013 at 5:38 PM, Glenn Adams gl...@skynav.com wrote:
On Mon, Feb 25, 2013 at 6:17 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Mon, Feb 25, 2013 at 5:06 PM, Glenn Adams gl...@skynav.com wrote:
On Mon, Feb 25, 2013 at 5:27 PM, Ryosuke Niwa rn...@webkit.org wrote:
Quite
On Mon, Feb 25, 2013 at 6:28 PM, Silvia Pfeiffer silvi...@chromium.orgwrote:
On Tue, Feb 26, 2013 at 9:34 AM, Ryosuke Niwa rn...@webkit.org wrote:
It should be fairly straight forward to create a tool that analyzes files
changed in each commit and deduce which tests' expected results have
24 matches
Mail list logo
