Re: [webkit-dev] Cross-platform fonts for Layout Tests

2011-06-07 Thread Hao Zheng
For example: fast/borders/borderRadiusArcs01.html svg/W3C-SVG-1.1-SE/pservers-pattern-04-f.svg fast/backgrounds/body-generated-image-propagated-to-root.html Hundreds of tests with skia drawing are affected by this bug, e.g. svg-tests, round-corner, gradient, etc. On Tue, Jun 7, 2011 at 11:58 PM,

Re: [webkit-dev] Cross-platform fonts for Layout Tests

2011-06-07 Thread Dirk Pranke
Reftests? -- Dirk On Mon, Jun 6, 2011 at 11:00 PM, Hao Zheng wrote: > Unfortunately, even for SVG or images, different drawing > implementations will lead to different pixel results. Like this Skia > bug, http://code.google.com/p/skia/issues/detail?id=179 , which caused > most pages using SkFixe

Re: [webkit-dev] Cross-platform fonts for Layout Tests

2011-06-06 Thread Hao Zheng
Unfortunately, even for SVG or images, different drawing implementations will lead to different pixel results. Like this Skia bug, http://code.google.com/p/skia/issues/detail?id=179 , which caused most pages using SkFixed calculation, e.g. round-corner, gradient, svg, etc., produce different render

Re: [webkit-dev] Cross-platform fonts for Layout Tests

2011-06-06 Thread Eric Seidel
So are we saying it's impossible to have matching results across all platforms if a test involves any text (in any font)? I know it's certainly possible to have pixel-results for tests which do not involve text match across all platforms (like SVG or images or css styling, etc.) Or is all this ju

Re: [webkit-dev] Cross-platform fonts for Layout Tests

2011-06-06 Thread Hao Zheng
Yes, actually in Skia, Chromium/Linux uses a noop gamma implementation in SkFontHost_gamma_none.cpp; however, if you use a substantial implementation in SkFontHost_gamma.cpp, there will be much image mismatch on Chromium/Linux for every font including Ahem. The slight differences are on font fringe

Re: [webkit-dev] Cross-platform fonts for Layout Tests

2011-06-02 Thread Tony Chang
Perhaps, but in practice, it's not enough. Here's an ahem pixel test that is slightly different on Mac and Chromium Linux: http://trac.webkit.org/browser/trunk/LayoutTests/platform/mac/fast/block/basic/010-expected.png http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium-linux/fast/b

Re: [webkit-dev] Cross-platform fonts for Layout Tests

2011-06-02 Thread Adam Barth
I thought the whole point of Ahem was to avoid those problems. Adam On Thu, Jun 2, 2011 at 1:29 AM, Hao Zheng wrote: > Actually, even the same Ahem font will be rendered differently on > different platform, depending on the font drawing library, the > anti-aliasing algorithm, subpixel, tiny flo

Re: [webkit-dev] Cross-platform fonts for Layout Tests

2011-06-02 Thread Hao Zheng
Actually, even the same Ahem font will be rendered differently on different platform, depending on the font drawing library, the anti-aliasing algorithm, subpixel, tiny float-point calculation diff on different arch. On Thu, Jun 2, 2011 at 3:30 AM, Eric Seidel wrote: > I know that Ahem is safe to

[webkit-dev] Cross-platform fonts for Layout Tests

2011-06-01 Thread Eric Seidel
I know that Ahem is safe to use across multiple platforms (the font metrics will be the same). Do we know if there are any other fonts for which this is true? I'd like to make the style-bot yell at people when they use pixel tests with non-safe fonts. Right now that list would only include ahem.