[webkit-dev] Curl resourcehandle leaks in Linux/Gtk port

2008-09-10 Thread zaheer ahmad
hi, In the linux Gtk port, with Webkit revision 33493, i see that the resource handles (curl backend) never get released after completing the data transfer for that request. This results in big leaks in resourcehandles as well as the curl internal data structures. (~800k on opening nytimes.com

Re: [webkit-dev] Curl resourcehandle leaks in Linux/Gtk port

2008-09-10 Thread Marco Barisione
Il giorno mer, 10/09/2008 alle 13.26 +0530, zaheer ahmad ha scritto: hi, In the linux Gtk port, with Webkit revision 33493, i see that the resource handles (curl backend) never get released after completing the data transfer for that request. This results in big leaks in resourcehandles as

Re: [webkit-dev] Curl resourcehandle leaks in Linux/Gtk port

2008-09-10 Thread Marco Barisione
Il giorno mer, 10/09/2008 alle 13.26 +0530, zaheer ahmad ha scritto: hi, In the linux Gtk port, with Webkit revision 33493, i see that the resource handles (curl backend) never get released after completing the data transfer for that request. This results in big leaks in resourcehandles as

Re: [webkit-dev] Curl resourcehandle leaks in Linux/Gtk port

2008-09-10 Thread Marco Barisione
Il giorno mer, 10/09/2008 alle 07.22 -0700, Mike Emmel ha scritto: This leak is fixed in the ncurl port. Is it possible to backport the fix? -- Marco Barisione ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Curl resourcehandle leaks in Linux/Gtk port

2008-09-10 Thread zaheer ahmad
hi, The fix only helps little as we see the bigger leaks in curl. feedback from curl experts suggests that this design is correct.. let me know if you are aware of this issue == here's the mail snapshot. we are seeing big leaks in curl (Curl_connect - 600-800k and Curl_open - ~200k) when we

Re: [webkit-dev] Curl resourcehandle leaks in Linux/Gtk port

2008-09-10 Thread Mike Emmel
Look I had to change to one multi handle per handle basically just and asynchronous handle to get everything to clean up. Its a significant refactoring and better design. What it points to on the curl side is the need for and asynchronous simple handle. Also polling was removed as much as

Re: [webkit-dev] Curl resourcehandle leaks in Linux/Gtk port

2008-09-10 Thread zaheer ahmad
hi mike, The ncurl port is not yet in the official builds. meanwhile how do you suggest to fix this in the current baseline. one of the changes that does help is to periodically cleanup the multihandle when the running job count drops to 0 and recreate on the next request (this is just a

Re: [webkit-dev] Curl resourcehandle leaks in Linux/Gtk port

2008-09-10 Thread Mike Emmel
On Wed, Sep 10, 2008 at 10:15 PM, zaheer ahmad [EMAIL PROTECTED] wrote: hi mike, The ncurl port is not yet in the official builds. meanwhile how do you suggest to fix this in the current baseline. No suggestions. I wrote he original code and did not care much for it even when I wrote it. I was