Re: [webkit-dev] ENABLE macro placement between includes

2023-08-15 Thread Kirsling, Ross via webkit-dev
I would support specifying the common pattern in our styleguide. Ross From: Alex Christensen via webkit-dev Reply-To: Alex Christensen Date: Thursday, August 3, 2023 at 2:52 PM To: Webkit Development List Subject: [webkit-dev] ENABLE macro placement between includes Our coding style says

[webkit-dev] ENABLE macro placement between includes

2023-08-02 Thread Alex Christensen via webkit-dev
Our coding style says to include config.h, then the primary header, then other headers. It does not say where to put any ENABLE macros in that list. We have about 1700 places where we follow this pattern: #include "config.h" #include "RemoteSampler.h" #if ENABLE(GPU_PROCESS) … #endif We have