[webkit-dev] Enum naming style?

2008-10-01 Thread Eric Seidel
According to the WebKit style http://webkit.org/coding/coding-style.html Names: 10. Enum members should user InterCaps with an initial capital letter. Our enums seem to use every style imaginable: enum EditorDeleteAction { deleteSelectionAction, deleteKeyAction,

Re: [webkit-dev] Enum naming style?

2008-10-01 Thread Peter Kasting
On Wed, Oct 1, 2008 at 4:01 PM, Eric Seidel [EMAIL PROTECTED] wrote: enum Color { Brown, Red, Blue } I've always been a fan of this, personally... One can use Color::Brown to solve ambiguities if necessary, but stick with just Brown in most scenarios. PK

Re: [webkit-dev] Enum naming style?

2008-10-01 Thread Geoffrey Garen
I would argue for enum Color { BrownColor }; I believe (based on recent patch reviews) that we have undocumented consensus that this style of first-letter-capitalized CamelCase is preferred for enums. I tend to agree with Peter that the Color suffix is unnecessary, but I'm not sure if

Re: [webkit-dev] Enum naming style?

2008-10-01 Thread Sam Weinig
On Wed, Oct 1, 2008 at 4:01 PM, Eric Seidel [EMAIL PROTECTED] wrote: enum SVGStitchOptions { SVG_STITCHTYPE_UNKNOWN = 0, SVG_STITCHTYPE_STITCH = 1, SVG_STITCHTYPE_NOSTITCH = 2 }; This style is usually used to stay consistent with the DOM IDLs. I don't think we should change

Re: [webkit-dev] Enum naming style?

2008-10-01 Thread Paul Pedriana
One can use Color::Brown to solve ambiguities if necessary That would be invalid C++. If a given compiler accepts it then the compiler is not strictly conforming. See the C++ Standard section 7.2 and section 9.2 p1. A scoping operator prefixed to an enumerand refers to the enclosing scope

Re: [webkit-dev] Enum naming style?

2008-10-01 Thread Peter Kasting
On Wed, Oct 1, 2008 at 5:11 PM, Paul Pedriana [EMAIL PROTECTED] wrote: One can use Color::Brown to solve ambiguities if necessary That would be invalid C++. If a given compiler accepts it then the compiler is not strictly conforming. See the C++ Standard section 7.2 and section 9.2 p1.