Re: [webkit-dev] Hash tables and unique string identifiers in JavaScriptCore

2012-09-19 Thread Geoffrey Garen
> Thanks! Do you mind pointing me to where this happens in the code? (passing > an Identifer to a C++ helper?) Here's an example function called by the JIT, from DFGOperations.cpp: void DFG_OPERATION operationPutByIdNonStrict(ExecState* exec, EncodedJSValue encodedValue, JSCell* base, Identifie

Re: [webkit-dev] Hash tables and unique string identifiers in JavaScriptCore

2012-09-19 Thread Stephen Lin
On Wed, Sep 19, 2012 at 1:32 AM, Geoffrey Garen wrote: > > Thanks! So is PropertyMapHashTable for properties that have been defined > by the user, or is it not that simple? > > Yes. > > > Apologies. Basically, does the implementation of object property access > in the JIT codebase also use string

Re: [webkit-dev] Hash tables and unique string identifiers in JavaScriptCore

2012-09-18 Thread Geoffrey Garen
> Thanks! So is PropertyMapHashTable for properties that have been defined by > the user, or is it not that simple? Yes. > Apologies. Basically, does the implementation of object property access in > the JIT codebase also use strings which have been made unique identifiers in > the same way a

Re: [webkit-dev] Hash tables and unique string identifiers in JavaScriptCore

2012-09-18 Thread Stephen Lin
On Wed, Sep 19, 2012 at 1:12 AM, Geoffrey Garen wrote: > Hi Stephen. > > > 1. I notice there are at least two implementations of hash tables in > JavaScriptCore/runtime, in Lookup.h and PropertyMapHashTable.h. Which, if > either, is used in, say, the normal case of accessing the properties of a >

Re: [webkit-dev] Hash tables and unique string identifiers in JavaScriptCore

2012-09-18 Thread Geoffrey Garen
Hi Stephen. > 1. I notice there are at least two implementations of hash tables in > JavaScriptCore/runtime, in Lookup.h and PropertyMapHashTable.h. Which, if > either, is used in, say, the normal case of accessing the properties of a DOM > element, like "window.location", etc.? And assuming it

[webkit-dev] Hash tables and unique string identifiers in JavaScriptCore

2012-09-18 Thread Stephen Lin
Hi, I just started working with webkit (specificially JSC) and am trying to learn the codebase. I hope someone can bear with me enough to help me with some questions: 1. I notice there are at least two implementations of hash tables in JavaScriptCore/runtime, in Lookup.h and PropertyMapHashTable.