Hi WebKit Developers,
As nice as it may be to have a bot landing your patches, I think developers
who have a commit bit should try and make the effort to land their own
patches. Mainly I think this is a good idea since the creator of the patch
has a much better chance of fixing the issue or
Has this actually been a problem? I know the commit-queue broke
something today when landing a patch for Evan Martin, but he was on
IRC and I made sure he was on the hook to watch the bots before I had
to leave. If I've landed things via commit-queue and not cleaned up
after them, I certainly
On Wed, Oct 14, 2009 at 9:21 AM, Evan Martin e...@chromium.org wrote:
I think the lesson I've learned with this change is that I shouldn't
tackle hard bugs to get started in WebKit.
I agree that it's a good idea to start small, the same way the
Chromium project asks new contributors to start
On Wed, Oct 14, 2009 at 10:25 AM, David Hyatt hy...@apple.com wrote:
On Oct 14, 2009, at 1:22 AM, Sam Weinig wrote:
(most patches probably won't break a build, unless you are named Dave
Hyatt).
Unnecessary. Wow.
T-shirts never lie
http://www.cafepress.com/tinderbox.1417340
On Wed, Oct 14, 2009 at 12:38 AM, Adam Barth aba...@webkit.org wrote:
Has this actually been a problem? I know the commit-queue broke
something today when landing a patch for Evan Martin, but he was on
IRC and I made sure he was on the hook to watch the bots before I had
to leave. If I've
On Wed, Oct 14, 2009 at 9:56 AM, Adam Barth aba...@webkit.org wrote:
WebKit doesn't have the same green tree aesthetic as Chromium does.
I think the main reason is because WebKit gets about half as many
commits per hour as the main Chromium tree and the commits are more
spread out over a 24hr
It seems like if you are a committer, you should still be able to use the
commit queue, you just need to do it responsibly. If the problem is with
people setting the bit and walking away, why not include a warning to the
effect of: Setting commit-queue+ is equivalent to svn commit so it is
This only works when you set the commit-queue+ bit. Currently, the
convention is that people without commit access set commit-queue? to signal
that they'd like a reviewer to commit-queue+ it when they r+ it. Sometimes
reviewers will go so far as to commit-queue+ it unless they see a
8 matches
Mail list logo
