Re: [webkit-dev] Name nitpick: layout tests

2010-08-04 Thread Zoltan Horvath
On Mon, Aug 2, 2010 at 7:33 AM, Dan Bernstein m...@apple.com wrote: On Aug 2, 2010, at 4:28 AM, Alexey Proskuryakov wrote: 29.07.2010, в 10:59, Darin Adler написал(а): The directory should be eventually be named Tests or WebKitTests or RegressionTests. Ideally, the directory

Re: [webkit-dev] Name nitpick: layout tests

2010-08-03 Thread Aaron Boodman
On Mon, Aug 2, 2010 at 9:40 AM, Darin Fisher da...@chromium.org wrote: On Mon, Aug 2, 2010 at 7:33 AM, Dan Bernstein m...@apple.com wrote: On Aug 2, 2010, at 4:28 AM, Alexey Proskuryakov wrote: 29.07.2010, в 10:59, Darin Adler написал(а): The directory should be eventually be named

Re: [webkit-dev] Name nitpick: layout tests

2010-08-03 Thread Darin Adler
I don’t buy in to this at all. We have done many successful renaming projects in the past. The future is bigger than the past and it’s worthwhile to do maintenance like this. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Name nitpick: layout tests

2010-08-03 Thread Aaron Boodman
On Tue, Aug 3, 2010 at 1:27 PM, Darin Adler da...@apple.com wrote: I don’t buy in to this at all. We have done many successful renaming projects in the past. The future is bigger than the past and it’s worthwhile to do maintenance like this. Okie. - a

Re: [webkit-dev] Name nitpick: layout tests

2010-08-02 Thread Alexey Proskuryakov
29.07.2010, в 10:59, Darin Adler написал(а): The directory should be eventually be named Tests or WebKitTests or RegressionTests. Ideally, the directory will have a unique first letter for better tab completion - so WebKitTests is a poor option from that point of view. I like the other

Re: [webkit-dev] Name nitpick: layout tests

2010-08-02 Thread Dan Bernstein
On Aug 2, 2010, at 4:28 AM, Alexey Proskuryakov wrote: 29.07.2010, в 10:59, Darin Adler написал(а): The directory should be eventually be named Tests or WebKitTests or RegressionTests. Ideally, the directory will have a unique first letter for better tab completion - so

Re: [webkit-dev] Name nitpick: layout tests

2010-08-02 Thread Darin Fisher
On Mon, Aug 2, 2010 at 7:33 AM, Dan Bernstein m...@apple.com wrote: On Aug 2, 2010, at 4:28 AM, Alexey Proskuryakov wrote: 29.07.2010, в 10:59, Darin Adler написал(а): The directory should be eventually be named Tests or WebKitTests or RegressionTests. Ideally, the directory

[webkit-dev] Name nitpick: layout tests

2010-07-29 Thread Darin Adler
Hi folks. WebKit regression tests are in a directory named LayoutTests. The object the tests uses to do special test-specific operations is layoutTestController. Both of these names are unwanted baggage, left over from when the test machinery was only good for testing layout. The directory

Re: [webkit-dev] Name nitpick: layout tests

2010-07-29 Thread Ryosuke Niwa
On Thu, Jul 29, 2010 at 10:59 AM, Darin Adler da...@apple.com wrote: The directory should be eventually be named Tests or WebKitTests or RegressionTests. Eric Seidel can probably remember talking this over with me the day after we added the LayoutTests directory; sorry that I never fixed it!

Re: [webkit-dev] Name nitpick: layout tests

2010-07-29 Thread Darin Adler
On Jul 29, 2010, at 11:09 AM, Ryosuke Niwa wrote: But I'm not sure if converting all the existing tests is feasible or worth the effort. Is there any practical problem other than being semantically wrong? This is not something we have to decide up front. Converting the existing tests is

Re: [webkit-dev] Name nitpick: layout tests

2010-07-29 Thread Dirk Pranke
On Thu, Jul 29, 2010 at 10:59 AM, Darin Adler da...@apple.com wrote: Hi folks. WebKit regression tests are in a directory named LayoutTests. The object the tests uses to do special test-specific operations is layoutTestController. Both of these names are unwanted baggage, left over from

Re: [webkit-dev] Name nitpick: layout tests

2010-07-29 Thread Kenneth Christiansen
I'm fine with it as well; the name confuses a lot of new contributors. Kenneth On Thu, Jul 29, 2010 at 3:15 PM, Dirk Pranke dpra...@chromium.org wrote: On Thu, Jul 29, 2010 at 10:59 AM, Darin Adler da...@apple.com wrote: Hi folks. WebKit regression tests are in a directory named LayoutTests.