Re: [webkit-dev] Platform specific editing behaviors

2010-10-28 Thread Andreas Kling
On 10/27/2010 11:17 PM, ext Antonio Gomes wrote: Before anything I would like to point it our here, and hear from the port maintainers any possible objection about it, specially from the cross-platform ones, including Chromium and Qt. This sounds like what we want for Qt, so no objections

[webkit-dev] Platform specific editing behaviors

2010-10-27 Thread Antonio Gomes
Hi. In bug https://bugs.webkit.org/show_bug.cgi?id=36627 (Needs a LinuxEditingBehavior, perhaps with a better name) , in order to supply needs that the existing editing behaviors (Mac and Windows) do not cover, we are going to add a new editing behavior type. The name is not defined yet, and our

Re: [webkit-dev] Platform specific editing behaviors

2010-10-27 Thread Ojan Vafai
This matches Chromium's desired behavior and is only a change for Chromium Linux. So, no objections there. On Wed, Oct 27, 2010 at 2:17 PM, Antonio Gomes toniki...@gmail.com wrote: Hi. In bug https://bugs.webkit.org/show_bug.cgi?id=36627 (Needs a LinuxEditingBehavior, perhaps with a better

Re: [webkit-dev] Platform specific editing behaviors

2010-10-27 Thread Antonio Gomes
Hi. Thanks for the feedback, Ojan and Ryosuke. From the experiments I've been doing, I think it will be a smooth landind. The platform specific editing behavior code paths are not that common in the tests in LayoutTests/editing, and the tests that go through them were converted to use the