On Fri, Mar 22, 2013 at 3:07 PM, Ryosuke Niwa wrote:
>
> Landed it in http://trac.webkit.org/changeset/146657. Once EWS bots catch
> up, we can start grabbing both text and pixel results off of Chromium and
> Mac EWS bots.
>
Thanks, this will be very useful!
_
On Fri, Mar 22, 2013 at 1:12 AM, Ryosuke Niwa wrote:
> On Thu, Mar 21, 2013 at 1:57 AM, Ryosuke Niwa wrote:
>
>> On Thu, Mar 21, 2013 at 1:31 AM, Robert Hogan wrote:
>>
>>> On Thursday, 21 March 2013, Ryosuke Niwa wrote:
>>>
I used to pull results from the bots where possible but creating
>
On Thu, Mar 21, 2013 at 1:57 AM, Ryosuke Niwa wrote:
> On Thu, Mar 21, 2013 at 1:31 AM, Robert Hogan wrote:
>
>> On Thursday, 21 March 2013, Ryosuke Niwa wrote:
>>
>>> I used to pull results from the bots where possible but creating
inconsistency between png/text results is not good.
>>
On Thu, Mar 21, 2013 at 11:16 AM, Ryosuke Niwa wrote:
> On Thu, Mar 21, 2013 at 10:54 AM, Žan Doberšek wrote:
>
>> On Thu, Mar 21, 2013 at 5:18 PM, Robert Hogan wrote:
>>
>>> On Thursday, 21 March 2013, Ryosuke Niwa wrote:
>>>
On Thu, Mar 21, 2013 at 1:31 AM, Robert Hogan wrote:
> O
I wish I could explicitly set an entry as being intended to be rebaselined,
then notified (by email, by webkit-patch, something) when the tests covered
by that entry have ran through all the bots with a url that shows the
results so I can quickly validate them. In this magic world, if the results
On Thu, Mar 21, 2013 at 10:54 AM, Žan Doberšek wrote:
> On Thu, Mar 21, 2013 at 5:18 PM, Robert Hogan wrote:
>
>> On Thursday, 21 March 2013, Ryosuke Niwa wrote:
>>
>>> On Thu, Mar 21, 2013 at 1:31 AM, Robert Hogan wrote:
>>>
On Thursday, 21 March 2013, Ryosuke Niwa wrote:
> I used
On Thu, Mar 21, 2013 at 5:18 PM, Robert Hogan wrote:
>
>
> On Thursday, 21 March 2013, Ryosuke Niwa wrote:
>
>> On Thu, Mar 21, 2013 at 1:31 AM, Robert Hogan wrote:
>>
>>> On Thursday, 21 March 2013, Ryosuke Niwa wrote:
>>>
I used to pull results from the bots where possible but creating
>>>
On Thursday, 21 March 2013, Ryosuke Niwa wrote:
> On Thu, Mar 21, 2013 at 1:31 AM, Robert Hogan
>
> > wrote:
>
>> On Thursday, 21 March 2013, Ryosuke Niwa wrote:
>>
>>> I used to pull results from the bots where possible but creating
inconsistency between png/text results is not good.
On Thu, Mar 21, 2013 at 1:31 AM, Robert Hogan wrote:
> On Thursday, 21 March 2013, Ryosuke Niwa wrote:
>
>> I used to pull results from the bots where possible but creating
>>> inconsistency between png/text results is not good.
>>>
>>
>> It is unfortunate but it's much better than losing the com
On Thursday, 21 March 2013, Ryosuke Niwa wrote:
> I used to pull results from the bots where possible but creating
>> inconsistency between png/text results is not good.
>>
>
> It is unfortunate but it's much better than losing the complete test
> coverage.
>
If that's the case then I'm happy to
To give you a perspective on how bad the current system is, just while I
was removing those 30 entires, I've found out that
fast/css-generated-content/table-row-group-to-inline.html has regressed
since it was first added. This regression should have caught by people
running pixel tests only if we h
On Wed, Mar 20, 2013 at 11:46 PM, Robert Hogan wrote:
> On Wednesday, 20 March 2013, Ryosuke Niwa wrote:
>
>> Please don't add lines to TestExpectations saying that they just need
>> rebaselines and then leave.
>>
>
> OK. That means I will have to pull the new results from the bots, which is
> fin
On Wednesday, 20 March 2013, Ryosuke Niwa wrote:
> Please don't add lines to TestExpectations saying that they just need
> rebaselines and then leave.
>
>
OK. That means I will have to pull the new results from the bots, which is
fine - but in the case of the Mac port (and any other bot that does
I remove test cases which need to do rebaseline on EFL TestExpectations
file.
http://trac.webkit.org/changeset/146432
The removed test cases are going to be done rebaseline.
Gyuyoung.
On Thu, Mar 21, 2013 at 9:59 AM, Gyuyoung Kim wrote:
> Hi,
>
> It looks EFL port has ~ 60 test cases which say
Hi,
It looks EFL port has ~ 60 test cases which say to do rebaseline in
TestExpectations file. I will remove them soon.
Gyuyoung.
On Thu, Mar 21, 2013 at 9:24 AM, Ryosuke Niwa wrote:
> e.g. just in this afternoon, I was able to remove ~30 entries from
> platform/mac/TestExpectations.
>
>
> htt
e.g. just in this afternoon, I was able to remove ~30 entries from
platform/mac/TestExpectations.
http://trac.webkit.org/changeset?new=146417%40trunk%2FLayoutTests%2Fplatform%2Fmac%2FTestExpectations&old=146296%40trunk%2FLayoutTests%2Fplatform%2Fmac%2FTestExpectations
I bet there are a lot more e
Please don't add lines to TestExpectations saying that they just need
rebaselines and then leave.
That would reduce the test coverage we have, and effectively disables the
test. If you're adding those entires, please be sure to remove them
ASAP. Better yet, don't add them unless you have to rebase
17 matches
Mail list logo
