I'm happy to give the Chromium project as much time as it needs to
remove these dependencies on Python 2.5, but I'd like to set a
deadline so that the WebKit project doesn't need to support Python 2.5
indefinitely. Is three months sufficient?
(I'm happy to help make this happen on the Chromium si
The bot step that runs ui_tests uses scripts/slave/runtest.py. You could
probably set PATH in that script before launching ui_tests.
http://build.chromium.org/p/chromium/builders/Mac10.5%20Tests%20%282%29/builds/10395/steps/ui_tests/logs/stdio
http://src.chromium.org/viewvc/chrome/trunk/tools/bui
(Sorry if we're spamming webkit-dev with this thread. We can move it
to a Chromium infrastructure mailing list if we're bugging anyone.)
On Thu, Nov 17, 2011 at 5:17 PM, Dirk Pranke wrote:
> On Thu, Nov 17, 2011 at 5:06 PM, Eric Seidel wrote:
>> On Thu, Nov 17, 2011 at 4:53 PM, Tony Chang wrot
On Thu, Nov 17, 2011 at 5:06 PM, Eric Seidel wrote:
> On Thu, Nov 17, 2011 at 4:53 PM, Tony Chang wrote:
>> new-run-webkit-httpd imports common/host.py which imports lots of stuff
>> including common/net/buildbot.py, which will fail to import the json module.
>> I would land smaller pieces so the
On Thu, Nov 17, 2011 at 4:53 PM, Tony Chang wrote:
> new-run-webkit-httpd imports common/host.py which imports lots of stuff
> including common/net/buildbot.py, which will fail to import the json module.
> I would land smaller pieces so the rollback isn't as painful. :)
Adam appears to have liste
I see. These servers integrate with the Port objects to do
port-specific processing.
Adam
On Thu, Nov 17, 2011 at 4:53 PM, Tony Chang wrote:
> new-run-webkit-httpd imports common/host.py which imports lots of stuff
> including common/net/buildbot.py, which will fail to import the json module.
new-run-webkit-httpd imports common/host.py which imports lots of stuff
including common/net/buildbot.py, which will fail to import the json module.
I would land smaller pieces so the rollback isn't as painful. :)
On Thu, Nov 17, 2011 at 4:42 PM, Adam Barth wrote:
> The remaining things seem re
The remaining things seem related to websocket-server and
new-run-webkit-httpd, which I don't think will be effected by your
change.
Adam
On Thu, Nov 17, 2011 at 4:40 PM, Eric Seidel wrote:
> Other bot steps in Chromium depend on webkitpy?
>
> I'm tempted to just make the change and see what br
On Thu, Nov 17, 2011 at 4:37 PM, Tony Chang wrote:
> Only new-run-webkit-tests uses python 2.7 on the leopard bots. There are
> other bot steps in chromium that would break. I mention a couple cases
> here:
> http://code.google.com/p/chromium/issues/detail?id=103266#c6
> Alternately, we could tr
Other bot steps in Chromium depend on webkitpy?
I'm tempted to just make the change and see what breaks. We can
always roll it out if things are really bad.
I'll prepare an updated patch.
-eric
On Thu, Nov 17, 2011 at 4:37 PM, Tony Chang wrote:
> Only new-run-webkit-tests uses python 2.7 on t
Only new-run-webkit-tests uses python 2.7 on the leopard bots. There are
other bot steps in chromium that would break. I mention a couple cases
here:
http://code.google.com/p/chromium/issues/detail?id=103266#c6
Alternately, we could try to fully switch the leopard bots to 2.7 (
http://crbug.com/
On Thu, Nov 17, 2011 at 2:45 PM, Adam Barth wrote:
> On Thu, Nov 17, 2011 at 2:42 PM, Dirk Pranke wrote:
>> The Chromium Leopard bots are still using 2.5 as far as I know. Unless
>> "move forward" includes you upgrading those bots, you shouldn't remove
>> the 2.5 compat code until they have been
On Thu, Nov 17, 2011 at 2:42 PM, Dirk Pranke wrote:
> The Chromium Leopard bots are still using 2.5 as far as I know. Unless
> "move forward" includes you upgrading those bots, you shouldn't remove
> the 2.5 compat code until they have been upgraded. (If you are signing
> up to upgrade them, then
What does this mean? Is there a bug tracking this in Chromium-world?
Given that Leopard is no longer a supported platform on
build.webkit.org (http://build.webkit.org/one_line_per_build), it
seems odd that Chromium would be behind like this.
-eric
On Thu, Nov 17, 2011 at 2:42 PM, Dirk Pranke w
The Chromium Leopard bots are still using 2.5 as far as I know. Unless
"move forward" includes you upgrading those bots, you shouldn't remove
the 2.5 compat code until they have been upgraded. (If you are signing
up to upgrade them, then great!).
-- Dirk
On Thu, Nov 17, 2011 at 2:24 PM, Eric Seide
I would like to move forward with this change.
Any further objections?
On Fri, Nov 4, 2011 at 3:20 PM, Eric Seidel wrote:
> Now that Apple has removed the Leopard build bot (and presumably
> stopped supporting WebKit on Leopard), all webkit platforms I know of
> have Python 2.6 or higher.
>
> My
Adam
>> -Original Message-
>> From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev-
>> boun...@lists.webkit.org] On Behalf Of Adam Barth
>> Sent: Monday, November 07, 2011 4:36 PM
>> To: Rafael Antognolli
>> Cc: WebKit Development
>> Subject:
day, November 07, 2011 4:36 PM
> To: Rafael Antognolli
> Cc: WebKit Development
> Subject: Re: [webkit-dev] Removing Support for Python 2.5
>
> $ /usr/bin/python2
> -bash: /usr/bin/python2: No such file or directory
>
> I have a pretty standard setup, so it looks like th
$ /usr/bin/python2
-bash: /usr/bin/python2: No such file or directory
I have a pretty standard setup, so it looks like that won't work for
most developers.
Adam
On Mon, Nov 7, 2011 at 1:08 PM, Rafael Antognolli
wrote:
> Hello, I should have asked on this thread before, but just saw it
> now.
Hello, I should have asked on this thread before, but just saw it
now. But since it's in the same topic, what do you think about
changing python scripts from using /usr/bin/python to /usr/bin/python2
?
I opened a bug for this some minutes ago:
https://bugs.webkit.org/show_bug.cgi?id=71723
Regard
Tony: I would recommend upgrading to at least 2.7 on those machines.
http://www.python.org/download/releases/2.7.2/
I would love to switch us to require 2.7 but such would currently too
much of a burden on SnowLeopard-based developers.
-eric
On Fri, Nov 4, 2011 at 4:03 PM, Adam Barth wrote:
> I
For those wishing to follow along at home (or just to spectate at the
epic-hack that was python 2.5 support), the bug is
https://bugs.webkit.org/show_bug.cgi?id=71593.
On Fri, Nov 4, 2011 at 4:03 PM, Adam Barth wrote:
> I misremembered. Looking at depot_tools, it seems Chromium only does
> this
I misremembered. Looking at depot_tools, it seems Chromium only does
this on Windows.
Looks like we might need to upgrade the Chromium bots to use 2.6.
Python 2.5 is super old at this point.
Adam
On Fri, Nov 4, 2011 at 4:01 PM, Tony Chang wrote:
> Are you sure? This output has references
> t
Are you sure? This output has references
to System/Library/Frameworks/Python.framework/Versions/2.5. I also thought
that's why NRWT was slow on the Leopard bots: python 2.5 doesn't have the
multiprocess module.
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%20%28dbg%29%281
Yes, Chromium versions its Python independently from the OS.
Adam
On Fri, Nov 4, 2011 at 3:25 PM, Ojan Vafai wrote:
> I believe the chromium port always uses 2.6 though, no?
>
> On Fri, Nov 4, 2011 at 3:23 PM, Nico Weber wrote:
>>
>> The chromium port still has a bot that runs tests (but doesn
I believe the chromium port always uses 2.6 though, no?
On Fri, Nov 4, 2011 at 3:23 PM, Nico Weber wrote:
> The chromium port still has a bot that runs tests (but doesn't build) on
> 10.5.
>
> Nico
>
> On Fri, Nov 4, 2011 at 3:20 PM, Eric Seidel wrote:
> > Now that Apple has removed the Leopard
The chromium port still has a bot that runs tests (but doesn't build) on 10.5.
Nico
On Fri, Nov 4, 2011 at 3:20 PM, Eric Seidel wrote:
> Now that Apple has removed the Leopard build bot (and presumably
> stopped supporting WebKit on Leopard), all webkit platforms I know of
> have Python 2.6 or h
Now that Apple has removed the Leopard build bot (and presumably
stopped supporting WebKit on Leopard), all webkit platforms I know of
have Python 2.6 or higher.
My plan is to remove all of our 2.5 supporting code in the next week,
requiring Python 2.6 or later for WebKit.
Let me know if this wil
28 matches
Mail list logo