Re: [webkit-dev] Unified sources have broken our #include hygiene

Hi, I've recently found two non-trivial issues with unified builds. They are not missing #include but instead conflicts between C++ files: - Two C++ files including the same header but with a #define directive set to different values [1]. - One C++ file including a header with implicit template

Re: [webkit-dev] Unified sources have broken our #include hygiene

> On Sep 1, 2018, at 19:25, Darin Adler wrote: > > I’ve long been interested in and wondered > whether we could use it, but it sort of does the opposite, and the “multiple > platforms” problem could well make even that tool impractical for us. I’ve spent a

Re: [webkit-dev] Unified sources have broken our #include hygiene

for headers without an associated .cpp. It would run clang-tidy and include-what-you-use. From: webkit-dev On Behalf Of Darin Adler Sent: Saturday, September 1, 2018 7:26 PM To: Simon Fraser Cc: WebKit Development Subject: Re: [webkit-dev] Unified sources have broken our #include hygiene On Sep 1

Re: [webkit-dev] Unified sources have broken our #include hygiene

FWIW, this problem is caused by unified sources *and* precompiled headers. > Unified sources allow you to get away without #including all the files you > need in a .cpp file, because some earlier file in the group has probably > already included them for you. > > This means that when you add a

Re: [webkit-dev] Unified sources have broken our #include hygiene

> On Sep 1, 2018, at 5:14 PM, Simon Fraser wrote: > > Unified sources allow you to get away without #including all the files you > need in a .cpp file, because some earlier file in the group has probably > already included them for you. > > This means that when you add a new file to the

Re: [webkit-dev] Unified sources have broken our #include hygiene

> On Sep 1, 2018, at 17:14, Simon Fraser wrote: > > Unified sources allow you to get away without #including all the files you > need in a .cpp file, because some earlier file in the group has probably > already included them for you. > > This means that when you add a new file to the

[webkit-dev] Unified sources have broken our #include hygiene

Unified sources allow you to get away without #including all the files you need in a .cpp file, because some earlier file in the group has probably already included them for you. This means that when you add a new file to the build, and the unified sources get shuffled around, you end up with