Re: [webkit-dev] Using ref tests for repaint bugs

2012-06-06 Thread Andrei Bucur
I want to give everyone an update on how things are evolving. For now, I've focused most of the development on the Mac platform. For the ref-tests-as-repaint-tests path, I've added an optional parameter to LTC.display() that should control if the repaint rectangles are tracked or not. If not

Re: [webkit-dev] Using ref tests for repaint bugs

2012-05-28 Thread Andrei Bucur
On Fri, May 25, 2012 at 4:05 PM, Julien Chaffraix julien.chaffr...@gmail.com wrote: I second Simon's fragility argument. His solution is more viable, platform agnostic and may even remove the need for dumping the pixel in some cases. Even if the existing harness has the subsequent paint

Re: [webkit-dev] Using ref tests for repaint bugs

2012-05-25 Thread Dominik Röttsches
Andrei, On 05/25/2012 02:43 AM, Andrei Bucur wrote: Ojan, As Simon states, some repaint tests will likely not be possible to write correctly as ref tests, but some of them I think they fit very well in the happy-no-pixel-test bucket :). If people decide it's a direction worth investigating,

Re: [webkit-dev] Using ref tests for repaint bugs

2012-05-25 Thread Julien Chaffraix
I think this will be too fragile. It relies on the fact that a subsequent paint won't obscure the repaint bug that you're trying to detect. I'm much rather we work towards detecting repaint bugs via dumping the list of repaint rectangles. I don't think every test has to be a ref test.

Re: [webkit-dev] Using ref tests for repaint bugs

2012-05-25 Thread Žan Doberšek
On Fri, May 25, 2012 at 9:57 AM, Dominik Röttsches dominik.rottsc...@intel.com wrote: Andrei, On 05/25/2012 02:43 AM, Andrei Bucur wrote: Ojan, As Simon states, some repaint tests will likely not be possible to write correctly as ref tests, but some of them I think they fit very well

Re: [webkit-dev] Using ref tests for repaint bugs

2012-05-25 Thread James Robinson
On Fri, May 25, 2012 at 1:42 PM, Žan Doberšek zandober...@gmail.com wrote: On Fri, May 25, 2012 at 9:57 AM, Dominik Röttsches dominik.rottsc...@intel.com wrote: Andrei, On 05/25/2012 02:43 AM, Andrei Bucur wrote: Ojan, As Simon states, some repaint tests will likely not be

Re: [webkit-dev] Using ref tests for repaint bugs

2012-05-24 Thread Ojan Vafai
Do you just need to force a layout at the end of repaintTest, e.g. document.body.offsetHeight;? On Thu, May 24, 2012 at 6:34 AM, Andrei Bucur andrei.bu...@gmail.comwrote: Hello WebKittens, I'm trying to simplify the patch for a certain repaint bug (

Re: [webkit-dev] Using ref tests for repaint bugs

2012-05-24 Thread Andrei Bucur
No, I need a way to force a paint operation, similar to what layoutTestController.display() achieves, but without tracking the paint rectangles. Does anyone you find value in adding an optional parameter to display (or create another method on LTC) that disables paint rectangle tracking. The

Re: [webkit-dev] Using ref tests for repaint bugs

2012-05-24 Thread Ojan Vafai
On Thu, May 24, 2012 at 3:59 PM, Andrei Bucur andrei.bu...@gmail.comwrote: No, I need a way to force a paint operation, similar to what layoutTestController.display() achieves, but without tracking the paint rectangles. Does anyone you find value in adding an optional parameter to display

Re: [webkit-dev] Using ref tests for repaint bugs

2012-05-24 Thread Simon Fraser
On May 24, 2012, at 3:59 PM, Andrei Bucur wrote: No, I need a way to force a paint operation, similar to what layoutTestController.display() achieves, but without tracking the paint rectangles. Does anyone you find value in adding an optional parameter to display (or create another

Re: [webkit-dev] Using ref tests for repaint bugs

2012-05-24 Thread Andrei Bucur
Ojan, As Simon states, some repaint tests will likely not be possible to write correctly as ref tests, but some of them I think they fit very well in the happy-no-pixel-test bucket :). If people decide it's a direction worth investigating, I'll give the idea a spin. Simon, On Fri, May 25, 2012