Re: [webkit-dev] WebKit Style: Whitespace for Objective-C protocols

2022-03-02 Thread Myles Maxfield via webkit-dev
I’ve posted a patch to make these changes official: https://bugs.webkit.org/show_bug.cgi?id=237406 > On Feb 24, 2022, at 9:09 AM, Darin Adler wrote: > > I personally prefer id, and would be happy to standardize on > that. I don’t really care that much about statistics about usage in our >

Re: [webkit-dev] WebKit Style: Whitespace for Objective-C protocols

2022-02-24 Thread Darin Adler via webkit-dev
I personally prefer id, and would be happy to standardize on that. I don’t really care that much about statistics about usage in our existing code. — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] WebKit Style: Whitespace for Objective-C protocols

2022-02-23 Thread Kimmo Kinnunen via webkit-dev
For my subjective opinion and personal project of supporting clang-format, the spacing could be this: id @interface WebSpeechRecognizerTaskImpl : NSObject On the grounds of: 1) No space for type declaration on the grounds that formatting the code would not need objective-c semantic

[webkit-dev] WebKit Style: Whitespace for Objective-C protocols

2022-02-21 Thread Myles Maxfield via webkit-dev
Hello! I was working on a patch recently where I wanted to give an Objective-C variable a type of “id that conforms to protocol Foo.” Should this be spelled like this: id myVariable Or like this: id myVariable I don’t see anything about this in the WebKit style guide