Re: [webkit-dev] WebKit style for switch statement

2010-01-20 Thread Eric Seidel
No, we leave out the default: That allows compilers to warn when cases are missing. Any time you see a default: in a WebCore switch, it's sub-optimal in my opinion. -eric On Wed, Jan 20, 2010 at 2:19 PM, Yong Li yong.li.web...@gmail.com wrote: As everyone may know, current webkit style (at

Re: [webkit-dev] WebKit style for switch statement

2010-01-20 Thread Darin Adler
On Jan 20, 2010, at 2:19 PM, Yong Li wrote: As everyone may know, current webkit style (at least for most source code) for a switch statement is like this: switch (var) { case valueFirst: ... break; ... case valueLast: ... break; default: ASSERT_NOT_REACHED() } That’s

Re: [webkit-dev] WebKit style for switch statement

2010-01-20 Thread Yong Li
Thanks, Eric, Darin. I get it. -Yong ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev