Re: [webkit-dev] WebKit unit test framework

2011-04-26 Thread Sam Weinig
I talked with Dave at the contributor meeting and I think we should try to move our existing tests over to GTest and see if we can get them all to pass and not be any slower. If that is doable, I think we should switch over. If, in the future, we find GTest to not have the features we need and

Re: [webkit-dev] WebKit unit test framework

2011-04-20 Thread David Levin
On Wed, Apr 20, 2011 at 4:59 PM, Darin Fisher wrote: > I believe both maruel and jcivelli have had experience contributing changes > to gtest. > > While I wouldn't characterize its code as simple, I haven't had trouble > understanding it. It is a fairly mature project, having been used > interna

Re: [webkit-dev] WebKit unit test framework

2011-04-20 Thread David Levin
On Wed, Apr 20, 2011 at 4:01 PM, Sam Weinig wrote: > Is a death test as scary as it sounds? > :) Useful if you want to verify that the program crashes. fwiw, chromium uses this to verify that asserts fire in debug in particular scenarios. ___ webkit-

Re: [webkit-dev] WebKit unit test framework

2011-04-20 Thread Darin Fisher
I believe both maruel and jcivelli have had experience contributing changes to gtest. While I wouldn't characterize its code as simple, I haven't had trouble understanding it. It is a fairly mature project, having been used internally at Google for ages. It seems to be fairly well maintained, an

Re: [webkit-dev] WebKit unit test framework

2011-04-20 Thread Sam Weinig
I am really not an expert on testing frameworks, and just put together something that met my needs (as has been the tradition in this project). That said, the only features I like about TestWebKitAPI is that I know how it works and can hack it to do what I want, and that it has the ability to

Re: [webkit-dev] WebKit unit test framework

2011-04-20 Thread David Levin
On Wed, Apr 20, 2011 at 3:00 PM, Timothy Hatcher wrote: > I think having something the WebKit community owns and controls is > preferred over importing and using a third-party library. > So that makes me prefer TestWebKitAPI (or something built from/on it) over > gtest. And TestWebKitAPI already

Re: [webkit-dev] WebKit unit test framework

2011-04-20 Thread Timothy Hatcher
I think having something the WebKit community owns and controls is preferred over importing and using a third-party library. So that makes me prefer TestWebKitAPI (or something built from/on it) over gtest. And TestWebKitAPI already has a very simple test for WTF::Vector — just begging to be ex

Re: [webkit-dev] WebKit unit test framework

2011-04-20 Thread Adam Barth
Looks like folks don't have a strong opinion about this topic. I'd recommend just picking something that works and giving it a try. I suspect many different frameworks would all work fine. Adam On Mon, Apr 18, 2011 at 11:48 AM, Dirk Pranke wrote: > I'd add "maintained" to your list, but other

Re: [webkit-dev] WebKit unit test framework

2011-04-18 Thread Dirk Pranke
I'd add "maintained" to your list, but otherwise it looks pretty good :) It would also be nice if the testing framework supported parallel or distributed execution, but not many do. -- Dirk On Mon, Apr 18, 2011 at 11:36 AM, David Levin wrote: > Issue: There has been a long standing bug to add u

[webkit-dev] WebKit unit test framework

2011-04-18 Thread David Levin
*Issue: *There has been a long standing bug to add unit tests to WebKit ( https://bugs.webkit.org/show_bug.cgi?id=21010). It was also mentionedon webkit-dev that it would be helpful in various cases. *Landscape:* Surveying