Re: [webkit-dev] Who are the EFL reviewers?

2011-04-12 Thread Gyuyoung Kim
I will do my best and thank you for your review again. - Gyuyoung From: Antonio Gomes [mailto:toniki...@gmail.com] Sent: Tuesday, April 12, 2011 10:52 PM To: Gyuyoung Kim Cc: webkit-dev@lists.webkit.org; 임상석 Subject: Re: [webkit-dev] Who are the EFL reviewers? I think the WebKit/EFL patches

Re: [webkit-dev] Who are the EFL reviewers?

2011-04-12 Thread Antonio Gomes
I think the WebKit/EFL patches are 100% valuable to be submitted to WebKit.org. ProFusion and Samsung are doing a great job improving the port, and we should not discourage them to keep contributing. I've been rubber-stamping and reviewing their contributions as much as I can, and I have to agree

Re: [webkit-dev] Who are the EFL reviewers?

2011-04-12 Thread Gyuyoung Kim
Kim) 5. Re: Who are the EFL reviewers? (Kenneth Rohde Christiansen) 6. Re: Who are the EFL reviewers? (Tomasz Morawski) -- Message: 1 Date: Sun, 10 Apr 2011 16:51:16 -0700 From: Eric Seidel To: WebKit Development Subject:

Re: [webkit-dev] Who are the EFL reviewers?

2011-04-12 Thread Gyuyoung Kim
2. Re: Who are the EFL reviewers? (Antonio Gomes) 3. How does webkit manage memory? (Corey Fu) 4. Re: webkit-dev Digest, Vol 71, Issue 8 (Gyuyoung Kim) 5. Re: Who are the EFL reviewers? (Kenneth Rohde Christiansen) 6. Re: Who are the EFL reviewers? (Tomasz Morawski)

Re: [webkit-dev] Who are the EFL reviewers?

2011-04-11 Thread Lucas De Marchi
On Sun, Apr 10, 2011 at 8:51 PM, Eric Seidel wrote: > We seem to have a zillion EFL patches up for review. > Who are the EFL reviewers? As other mentioned, as of now there are none. I've been doing some informal reviews, but it seems that I'm not receiving all the zillions of patches. Last Frida

Re: [webkit-dev] Who are the EFL reviewers?

2011-04-11 Thread Leandro Pereira
On Mon, Apr 11, 2011 at 1:08 PM, David Levin wrote: >> >> Hi, >> Is it possible to promote some other peoples to reviewers in the EFL >> port? > > A step that I usually suggest to chromium folks before becoming reviewers is > to actually do reviews on patches.  Do everything except the r+ (with th

Re: [webkit-dev] Who are the EFL reviewers?

2011-04-11 Thread Kenneth Rohde Christiansen
That sounds like a very good idea and I would be happy to help along giving the final r+ Kenneth On Mon, Apr 11, 2011 at 6:08 PM, David Levin wrote: > > > On Mon, Apr 11, 2011 at 3:40 AM, Tomasz Morawski > wrote: >> >> Hi, >> Is it possible to promote some other peoples to reviewers in the EFL

Re: [webkit-dev] Who are the EFL reviewers?

2011-04-11 Thread David Levin
On Mon, Apr 11, 2011 at 3:40 AM, Tomasz Morawski wrote: > Hi, > Is it possible to promote some other peoples to reviewers in the EFL > port? > A step that I usually suggest to chromium folks before becoming reviewers is to actually do reviews on patches. Do everything except the r+ (with the sub

Re: [webkit-dev] Who are the EFL reviewers?

2011-04-11 Thread Tomasz Morawski
Hi, Is it possible to promote some other peoples to reviewers in the EFL port? Tomasz The problem is that as I am not working on the port myself, I find it quite hard to review their API's without getting input from someone else working on EFL. I think Antonio feels likewise. Kenneth On Mon,

Re: [webkit-dev] Who are the EFL reviewers?

2011-04-11 Thread Kenneth Rohde Christiansen
The problem is that as I am not working on the port myself, I find it quite hard to review their API's without getting input from someone else working on EFL. I think Antonio feels likewise. Kenneth On Mon, Apr 11, 2011 at 2:13 AM, Antonio Gomes wrote: > Mostly myself and Kenneth. We do what we

Re: [webkit-dev] Who are the EFL reviewers?

2011-04-10 Thread Antonio Gomes
Mostly myself and Kenneth. We do what we can, but we also to work on our stuff (as everybody else :). It really needs other reviewers to help out with reviewing, since EFL port guys are working really hard on it. On Sun, Apr 10, 2011 at 7:51 PM, Eric Seidel wrote: > We seem to have a zillion EFL

[webkit-dev] Who are the EFL reviewers?

2011-04-10 Thread Eric Seidel
We seem to have a zillion EFL patches up for review. Who are the EFL reviewers? (I think part of the trouble is that it seems the EFL port is trying to do too much in WebKit. I'm not sure where the EFL browser is, but some of the patches look like they should be re-directed to that project inste