Re: [webkit-dev] bmalloc design question about relation with std malloc

2018-05-02 Thread Yusuke SUZUKI
Thanks, it sounds reasonable :) On Tue, May 1, 2018 at 1:47 Geoffrey Garen wrote: > If we have just a few allocations, we should use the mmap based allocator. > This preserves the invariant that bmalloc can be used as a general-purpose > malloc implementation. > > If we have

Re: [webkit-dev] bmalloc design question about relation with std malloc

2018-04-30 Thread Geoffrey Garen
If we have just a few allocations, we should use the mmap based allocator. This preserves the invariant that bmalloc can be used as a general-purpose malloc implementation. If we have lots of small allocations, we should probably reconsider the design. I’m not familiar with the new uses of

Re: [webkit-dev] bmalloc design question about relation with std malloc

2018-04-30 Thread Filip Pizlo
Ideally we would use the mmap allocator. But I wouldn’t do that if it causes a space usage regression, for example if we allocate a lot of small vectors. -Filip > On Apr 30, 2018, at 3:35 AM, Yusuke SUZUKI wrote: > > Hi, WebKittens, > > IIRC, bmalloc uses mmap based

[webkit-dev] bmalloc design question about relation with std malloc

2018-04-30 Thread Yusuke SUZUKI
Hi, WebKittens, IIRC, bmalloc uses mmap based page allocator for internal memory use. For example, bmalloc::Vector uses it instead of calling malloc. But recent changes start using std::vector, which means it uses std malloc under the hood. So my question is, if we want some internal memory