Also note Maciej's proposal about moving it to a build step.
I am for this idea, but in that case maybe I want the option to ignore
run-bindings-tests in the build.
When we change CodeGenerator*.pm, we repeat try error many times
until build succeeds. If we needed to update run-bindings-tests
Hi All,
It is observed that if changes are made in Codegenerator*.pm we need to
rebase results of run-bindings-tests.
Many times authors forgot to update these binding results.
IMO we should add check in ./check-webkit-style to warn/(give a chance)
author to run run-bindings-tests if
IMO we should add check in ./check-webkit-style to warn/(give a chance)
author to run run-bindings-tests if Codegenerator is modified.
+1 to the idea. I think that it would make sense to warn if any file
under WebCore/bindings/ is changed.
Another idea might be to run ./run-bindings-tests in
[Sending from a correct mail address...]
IMO we should add check in ./check-webkit-style to warn/(give a chance)
author to run run-bindings-tests if Codegenerator is modified.
+1 to the idea. I think that it would make sense to warn if any file
under WebCore/bindings/ is changed.
Another
We have discussed this before:
https://lists.webkit.org/pipermail/webkit-dev/2011-September/017868.html
A better change would be for us to generate the diff on EWS, and get rid of
binding tests step from build bots since they aren't really testing
anything. The primary use case of
Also note Maciej's proposal about moving it to a build step.
Either way, it shouldn't be ran as a test step on build bots.
- Ryosuke
On Mon, Apr 9, 2012 at 9:18 AM, Ryosuke Niwa rn...@webkit.org wrote:
We have discussed this before:
[From the correct email]
On Mon, Apr 9, 2012 at 12:26 PM, Jarred Nicholls jar...@sencha.com wrote:
On Mon, Apr 9, 2012 at 12:18 PM, Ryosuke Niwa rn...@webkit.org wrote:
We have discussed this before:
https://lists.webkit.org/pipermail/webkit-dev/2011-September/017868.html
A better change
7 matches
Mail list logo
