[webkit-dev] importing test suites (was: CSS 2.1 Test Suite)

2012-04-11 Thread Dirk Pranke
On Wed, Apr 11, 2012 at 12:31 PM, Robert Hogan li...@roberthogan.net wrote: On Wednesday 11 April 2012 20:27:23 Dirk Pranke wrote: What does clean up the existing folder entail? Just move any -expected.html file out of there and generate pixel results. Or move the test and its

Re: [webkit-dev] importing test suites (was: CSS 2.1 Test Suite)

2012-04-11 Thread Robert Hogan
On Wednesday 11 April 2012 23:29:56 Dirk Pranke wrote: 1) What is the best way to add these tests to the tree? Should we add them one-at-a-time with -expected files that we have created? Should we add them all at once and SKIP the tests until we have generated -expected results for each

Re: [webkit-dev] importing test suites (was: CSS 2.1 Test Suite)

2012-04-11 Thread Jacob Goldstein
+1 on not introducing new pixel tests and allowing someone other than the test author to create the -expected file. We may also be able to streamline some of this process by implementing some helper scripts. Ultimately, someone will still have to review new files manually, but scripts should be

Re: [webkit-dev] importing test suites (was: CSS 2.1 Test Suite)

2012-04-11 Thread Ryosuke Niwa
On Wed, Apr 11, 2012 at 3:52 PM, Jacob Goldstein jac...@adobe.com wrote: +1 on not introducing new pixel tests and allowing someone other than the test author to create the -expected file. We may also be able to streamline some of this process by implementing some helper scripts.

Re: [webkit-dev] importing test suites (was: CSS 2.1 Test Suite)

2012-04-11 Thread Jacob Goldstein
@lists.webkit.org Subject: Re: [webkit-dev] importing test suites (was: CSS 2.1 Test Suite) On Wed, Apr 11, 2012 at 3:52 PM, Jacob Goldstein jac...@adobe.commailto:jac...@adobe.com wrote: +1 on not introducing new pixel tests and allowing someone other than the test author to create the -expected file. We may

Re: [webkit-dev] importing test suites (was: CSS 2.1 Test Suite)

2012-04-11 Thread Dirk Pranke
On Wed, Apr 11, 2012 at 4:00 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Apr 11, 2012 at 3:52 PM, Jacob Goldstein jac...@adobe.com wrote: +1 on not introducing new pixel tests and allowing someone other than the test author to create the -expected file. We may also be able to streamline

Re: [webkit-dev] importing test suites (was: CSS 2.1 Test Suite)

2012-04-11 Thread Ryosuke Niwa
On Wed, Apr 11, 2012 at 4:05 PM, Jacob Goldstein jac...@adobe.com wrote: Don't people currently fix tests that are failing and that they didn't author? We don't fix imported tests if you meant modifying html files, etc... to fix a broken test file. If so, isn't that similar as generating a

Re: [webkit-dev] importing test suites (was: CSS 2.1 Test Suite)

2012-04-11 Thread Dirk Pranke
On Wed, Apr 11, 2012 at 4:15 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Apr 11, 2012 at 4:05 PM, Jacob Goldstein jac...@adobe.com wrote: Don't people currently fix tests that are failing and that they didn't author? We don't fix imported tests if you meant modifying html files, etc...