Re: [webkit-dev] sharing more test references

2012-11-14 Thread Robert Hogan
On Wed, Nov 14, 2012 at 12:01 AM, Dirk Pranke wrote: > > The way ref tests are currently implemented, there is no direct way to > say "use test X as a reference for test Y" (although this is in the > W3C specs for ref tests, which suggests using tags in the test > html). Previous conversations o

Re: [webkit-dev] sharing more test references

2012-11-13 Thread Dirk Pranke
On Tue, Nov 13, 2012 at 5:06 PM, Eric Seidel wrote: > > > > > Does seem pretty simple. > > > > > > is even shorter. :) > > I support getting rid of pixel tests. I suspect that some very dumb > scripts could turn large chunks of these existing pixel-tests into > ref-tests. I doubt that thos

Re: [webkit-dev] sharing more test references

2012-11-13 Thread Dirk Pranke
On Tue, Nov 13, 2012 at 4:59 PM, Darin Adler wrote: > On Nov 13, 2012, at 4:56 PM, Dirk Pranke wrote: > >> Wouldn't the fact that there are a large set of tests with the same result >> be an argument *for* doing the iframe thing? > > The simple hand-coded green square in upper left corner should

Re: [webkit-dev] sharing more test references

2012-11-13 Thread Eric Seidel
Does seem pretty simple. is even shorter. :) I support getting rid of pixel tests. I suspect that some very dumb scripts could turn large chunks of these existing pixel-tests into ref-tests. I doubt that those would be the interesting ones though (where platforms have divergent results)

Re: [webkit-dev] sharing more test references

2012-11-13 Thread Darin Adler
On Nov 13, 2012, at 4:56 PM, Dirk Pranke wrote: > Wouldn't the fact that there are a large set of tests with the same result be > an argument *for* doing the iframe thing? The simple hand-coded green square in upper left corner should be simple, perhaps even simpler than the iframe thing. > W

Re: [webkit-dev] sharing more test references

2012-11-13 Thread Dirk Pranke
On Tue, Nov 13, 2012 at 4:33 PM, Darin Adler wrote: > On Nov 13, 2012, at 4:01 PM, Dirk Pranke wrote: > >> It turns out that we have a reasonably large number of tests that produce >> the exact same pixel results. On chromium-mac on 10.8, for example, there >> are 2048 tests that share a result

Re: [webkit-dev] sharing more test references

2012-11-13 Thread Darin Adler
On Nov 13, 2012, at 4:01 PM, Dirk Pranke wrote: > It turns out that we have a reasonably large number of tests that produce the > exact same pixel results. On chromium-mac on 10.8, for example, there are > 2048 tests that share a result with some other test. 50 of them, for example, > draw a g

[webkit-dev] sharing more test references

2012-11-13 Thread Dirk Pranke
Hi all, Currently, we have ~8000 pixel tests in the tree, and ~800 reference tests. I would like to make that first number a lot smaller. It turns out that we have a reasonably large number of tests that produce the exact same pixel results. On chromium-mac on 10.8, for example, there are 2048 te