[webkit-dev] svn-create-patch acting oddly lately

2009-07-20 Thread Darin Adler
My patches look like this now: $ svn-create-patch svn: Path '../..' ends in '..', which is unsupported for this operation Index: ../../../../../Users/darin/Safari/OpenSource/WebKit/mac/WebView/ WebHTMLView.mm === ---

Re: [webkit-dev] svn-create-patch acting oddly lately

2009-07-20 Thread Peter Kasting
On Mon, Jul 20, 2009 at 1:28 PM, Darin Adler da...@apple.com wrote: My patches look like this now: $ svn-create-patch svn: Path '../..' ends in '..', which is unsupported for this operation This warning was caused by a change of mine that I checked in a fix for at noon on Friday. It

Re: [webkit-dev] svn-create-patch acting oddly lately

2009-07-20 Thread Peter Kasting
On Mon, Jul 20, 2009 at 1:55 PM, Eric Seidel esei...@google.com wrote: It could also be from http://trac.webkit.org/changeset/45939. Yes. Knowing Darin's repository version would help narrow this down. I am trying different things to see if I can reproduce locally. Once I can reproduce I

Re: [webkit-dev] svn-create-patch acting oddly lately

2009-07-20 Thread Adam Barth
It's kind of sad that we have so many ways of finding the SVN root. The code in that link isn't right. You need to look at the UUID to get the right answer. See scm.py. Adam On Mon, Jul 20, 2009 at 1:59 PM, Peter Kastingpkast...@google.com wrote: On Mon, Jul 20, 2009 at 1:55 PM, Eric Seidel

Re: [webkit-dev] svn-create-patch acting oddly lately

2009-07-20 Thread Peter Kasting
On Mon, Jul 20, 2009 at 2:03 PM, Adam Barth aba...@webkit.org wrote: It's kind of sad that we have so many ways of finding the SVN root. The code in that link isn't right. You need to look at the UUID to get the right answer. See scm.py. My update made us look at the Repository Root field

Re: [webkit-dev] svn-create-patch acting oddly lately

2009-07-20 Thread Joseph Pecoraro
It's kind of sad that we have so many ways of finding the SVN root. The code in that link isn't right. You need to look at the UUID to get the right answer. See scm.py. Yes, I saw scm.py's solution literally yesterday while I was learning how to use bugzilla-tool because I switched to git.

Re: [webkit-dev] svn-create-patch acting oddly lately

2009-07-20 Thread Peter Kasting
On Mon, Jul 20, 2009 at 2:11 PM, Joseph Pecoraro joepec...@gmail.comwrote: Yes, I saw scm.py's solution literally yesterday while I was learning how to use bugzilla-tool because I switched to git. In any case the newer revision uses a much better approach then the one in this changelog

Re: [webkit-dev] svn-create-patch acting oddly lately

2009-07-20 Thread Darin Adler
On Jul 20, 2009, at 1:38 PM, Peter Kasting wrote: On Mon, Jul 20, 2009 at 1:28 PM, Darin Adler da...@apple.com wrote: svn: Path '../..' ends in '..', which is unsupported for this operation This warning was caused by a change of mine that I checked in a fix for at noon on Friday. It

Re: [webkit-dev] svn-create-patch acting oddly lately

2009-07-20 Thread Darin Adler
On Jul 20, 2009, at 2:17 PM, Peter Kasting wrote: In the meantime, I've tried and failed to recreate Darin's problem locally, so I'm at the mercy of other people to report that they're having this problem. The key here is that /Users/darin is a symbolic link to /Volumes/ Home/darin — you

Re: [webkit-dev] svn-create-patch acting oddly lately

2009-07-20 Thread Darin Adler
On Jul 20, 2009, at 2:40 PM, Peter Kasting wrote: It looks from here like the chdir call is causing curdir() to report the non-symbolic-link form of things. If that's true, it seems like this workaround would work: Makes sense. ... my ($newdir) = @_; my $before = File::Spec-rel2abs(

Re: [webkit-dev] svn-create-patch acting oddly lately

2009-07-20 Thread Peter Kasting
On Mon, Jul 20, 2009 at 2:40 PM, Peter Kasting pkast...@google.com wrote: It looks from here like the chdir call is causing curdir() to report the non-symbolic-link form of things. If that's true, it seems like this workaround would work: ... my ($newdir) = @_; my $before =

Re: [webkit-dev] svn-create-patch acting oddly lately

2009-07-20 Thread Peter Kasting
On Mon, Jul 20, 2009 at 2:52 PM, Darin Adler da...@apple.com wrote: On Jul 20, 2009, at 2:50 PM, Peter Kasting wrote: my ($newdir) = @_; my $before = Cwd::getcwd(); chdir $newdir; my $after = Cwd::getcwd(); That seems like it ought to work a lot better. Yes, it does. Hooray!

Re: [webkit-dev] svn-create-patch acting oddly lately

2009-07-20 Thread Adam Barth
On Mon, Jul 20, 2009 at 2:17 PM, Peter Kastingpkast...@google.com wrote: I can switch svn-create-patch to using UUID if there are benefits over using the Repository Root; it'd literally be a four-character change. I'm not enough of an SVN expert to know which is better. I'd prefer to use one