Sounds like the majority of people would prefer to use { ~ }. We should
probably codify that in our code style guidelines.
> On Sep 23, 2024, at 5:15 PM, Gerald Squelart via webkit-dev
> wrote:
>
> +1 for { } as well, for all the mentioned good reasons.
>
> But just to be complete, there's on
+1 for { } as well, for all the mentioned good reasons.
But just to be complete, there's one exception that should probably be noted
if/when we document this:
For classes that have a constructor taking `std::initializer_list` and other
constructors that take `T` (+ conversions), using braced-ini
Looks like the majority opinion is to use { ~ }?
- R. Niwa
> On Sep 23, 2024, at 9:35 AM, Geoff Garen via webkit-dev
> wrote:
>
> +1 for { } because I like catching bugs.
>
> But also: If Chris is right that { } is the only way to handle types without
> constructors, and the goal is to pick
+1 for { } because I like catching bugs.
But also: If Chris is right that { } is the only way to handle types without
constructors, and the goal is to pick one syntax, then { } is the only possible
solution, because standardizing on = would require exceptions for types without
constructors.
Th
I prefer { } style.
It can catch implicit narrowing bugs, which does not work with = style.
Best regards,
- Yusuke
> On Sep 19, 2024, at 4:13 PM, Jean-Yves Avenard via webkit-dev
> wrote:
>
>
>
>> On 20 Sep 2024, at 7:55 AM, Ryosuke Niwa via webkit-dev
>> wrote:
>>
>>
>> Should we do:
>
> On 20 Sep 2024, at 7:55 AM, Ryosuke Niwa via webkit-dev
> wrote:
>
>
> Should we do:
>
> struct Foo {
> int bar = 0;
> }
>
> Or
>
> struct Foo {
> int bar { 0 };
> }
>
> We do both at the moment.
>
> - R. Niwa
I think `int bar = 0` reads better.
I only ever see (and use) { }
+1 for { }.
— Timothy Hatcher
> On Sep 19, 2024, at 2:55 PM, Ryosuke Niwa via webkit-dev
> wrote:
>
>
> Should we do:
>
> struct Foo {
> int bar = 0;
> }
>
> Or
>
> struct Foo {
> int bar { 0 };
> }
>
> We do both at the moment.
>
> - R. Niwa
>
>
No strong feelings but I have a slight preference for `{ }` initialization
since it disallows narrowing conversions and works with types that do not have
a declared constructor.
So if we have to align in one direction, it would be my preference.
Chris.
> On Sep 19, 2024, at 2:55 PM, Ryosuke Niw
8 matches
Mail list logo
